public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Daniel Drake <dsd@laptop.org>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	x86@kernel.org, rdunlap@xenotime.net,
	linux-kernel@vger.kernel.org, dilinger@queued.net
Subject: Re: [PATCH] x86, olpc: Fix dependency on POWER_SUPPLY
Date: Sun, 24 Jul 2011 20:15:12 +0200	[thread overview]
Message-ID: <20110724181512.GA24338@elte.hu> (raw)
In-Reply-To: <20110724173321.747BC9D401C@zog.reactivated.net>


* Daniel Drake <dsd@laptop.org> wrote:

> As reported by Randy Dunlap, CONFIG_POWER_SUPPLY=m caused a compile error:
> 
> arch/x86/built-in.o: In function `battery_status_changed':
> olpc-xo15-sci.c:(.text+0x3acdd): undefined reference to `power_supply_get_by_name'
> olpc-xo15-sci.c:(.text+0x3ad04): undefined reference to `power_supply_changed'
> 
> The SCI drivers, as bool, require POWER_SUPPLY to be builtin. Use
> select to make that a hard requirement and avoid this build failure.
> 
> Signed-off-by: Daniel Drake <dsd@laptop.org>

Note that we generally try to add a Reported-by tag in such cases. 

(i've added that, no need to resend.)

Thanks,

	Ingo

  parent reply	other threads:[~2011-07-24 18:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-24 17:33 [PATCH] x86, olpc: Fix dependency on POWER_SUPPLY Daniel Drake
2011-07-24 17:36 ` Randy Dunlap
2011-07-24 18:15 ` Ingo Molnar [this message]
2011-07-24 18:19   ` Daniel Drake
2011-07-24 18:24     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110724181512.GA24338@elte.hu \
    --to=mingo@elte.hu \
    --cc=dilinger@queued.net \
    --cc=dsd@laptop.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rdunlap@xenotime.net \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox