From: Al Viro <viro@ZenIV.linux.org.uk>
To: Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: kdevtmpfs oops since yesterdays vfs merge
Date: Mon, 25 Jul 2011 00:51:54 +0100 [thread overview]
Message-ID: <20110724235154.GO24703@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20110724234029.GA4881@redhat.com>
On Sun, Jul 24, 2011 at 07:40:29PM -0400, Dave Jones wrote:
> On Mon, Jul 25, 2011 at 12:28:12AM +0100, Al Viro wrote:
> > On Sun, Jul 24, 2011 at 07:17:01PM -0400, Dave Jones wrote:
> > > I see an oops in handle_create when I try to boot current tree..
> > >
> > > full trace:
> > > https://s3.amazonaws.com/twitpic/photos/large/355006460.jpg?AWSAccessKeyId=AKIAJF3XCCKACR3QDMOA&Expires=1311550232&Signature=IIO%2Bya1uEDJzSXTD0DXh2%2BdZpoU%3D
> >
> > Where in handle_create() is that? At least dump objdump -d of your
> > devtmpfs.o someplace readable...
>
> http://codemonkey.org.uk/devtmpfs.s
Smells like req->dev somehow managing to be NULL at that point, but that
doesn't make any sense - we get to devtmpfs_create_node() only from one
place, it sets req.dev to the argument it got from callers and that caller
would have oopsed itself before getting to that call with dev == NULL...
Could you stick a BUG_ON(!dev) in the beginning of handle_create() to see
if that's what somehow manages to happen?
next prev parent reply other threads:[~2011-07-24 23:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-24 23:17 kdevtmpfs oops since yesterdays vfs merge Dave Jones
2011-07-24 23:28 ` Al Viro
2011-07-24 23:40 ` Dave Jones
2011-07-24 23:51 ` Al Viro [this message]
2011-07-25 1:53 ` Dave Jones
2011-07-25 1:56 ` Dave Jones
2011-07-25 2:44 ` Al Viro
2011-07-25 4:58 ` Dave Jones
2011-07-25 5:12 ` Al Viro
2011-07-25 5:53 ` Dave Jones
2011-07-25 6:15 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110724235154.GO24703@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox