From: Al Viro <viro@ZenIV.linux.org.uk>
To: Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: kdevtmpfs oops since yesterdays vfs merge
Date: Mon, 25 Jul 2011 07:15:51 +0100 [thread overview]
Message-ID: <20110725061551.GR24703@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20110725055307.GA12234@redhat.com>
On Mon, Jul 25, 2011 at 01:53:08AM -0400, Dave Jones wrote:
> On Mon, Jul 25, 2011 at 06:12:51AM +0100, Al Viro wrote:
>
> > Arrgh... OK, I see what's going on.
> >
> > req->err = handle(req->name, req->mode, req->dev);
> > complete(&req->done);
> > req = req->next;
> > is letting the request creator to continue; if it leaves the scope, guess
> > what is left in *req? That's right, garbage... Including req->next.
> > All right, try this and let's see if it fixes the problem:
>
> Yep, that solves the problem.
OK, to Linus it goes tomorrow morning... I'm about to fall asleep right now
and queue needs a bit of reordering ;-/
prev parent reply other threads:[~2011-07-25 6:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-24 23:17 kdevtmpfs oops since yesterdays vfs merge Dave Jones
2011-07-24 23:28 ` Al Viro
2011-07-24 23:40 ` Dave Jones
2011-07-24 23:51 ` Al Viro
2011-07-25 1:53 ` Dave Jones
2011-07-25 1:56 ` Dave Jones
2011-07-25 2:44 ` Al Viro
2011-07-25 4:58 ` Dave Jones
2011-07-25 5:12 ` Al Viro
2011-07-25 5:53 ` Dave Jones
2011-07-25 6:15 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110725061551.GR24703@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox