* [PATCH] block: use the logical OR condition at blk_flush_complete_seq
@ 2011-07-25 11:03 Kyungmin Park
0 siblings, 0 replies; only message in thread
From: Kyungmin Park @ 2011-07-25 11:03 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-kernel
From: Kyungmin Park <kyungmin.park@samsung.com>
Even though the meaning is same, use the logical OR condition instead ORing.
seq blk_kick_flush(q) queued
1 1 0 => true
2 0 1 => true
8 0 0 => false
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
diff --git a/block/blk-flush.c b/block/blk-flush.c
index bb21e4c..66e0acb 100644
--- a/block/blk-flush.c
+++ b/block/blk-flush.c
@@ -187,7 +187,7 @@ static bool blk_flush_complete_seq(struct request *rq, unsigned int seq,
BUG();
}
- return blk_kick_flush(q) | queued;
+ return blk_kick_flush(q) || queued;
}
static void flush_end_io(struct request *flush_rq, int error)
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2011-07-25 11:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-25 11:03 [PATCH] block: use the logical OR condition at blk_flush_complete_seq Kyungmin Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox