From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Marcus Folkesson <marcus.folkesson@gmail.com>
Cc: lrg@slimlogic.co.uk, linux-kernel@vger.kernel.org
Subject: Re: regulator: tps65020 support
Date: Tue, 26 Jul 2011 09:50:44 +0100 [thread overview]
Message-ID: <20110726085043.GA7285@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAM8FrKK1z7euvURCH+ou8uNYumF82bn13oYfBOAiMNiB9zdBJA@mail.gmail.com>
On Tue, Jul 26, 2011 at 12:03:46AM +0200, Marcus Folkesson wrote:
> This patch gives support for the tps65020 voltage regulator from Texas
> Instruments.
> The support is added to the existing tps65023 regulator.
>
> It also fixes two bugs:
> * The original driver does not allow core voltage adjustments by the
> I2C bus. (clearing CORE ADJ bit in CTRL2 register).
> * The original driver does not either telling the chip that the
> DEFCORE register i changed by setting the GO bit in CTRL2.
>
> I have read SubmittingPatches and think all should be okay (this is my
> first submit :-) ), but I still have two questions:
No, a few more issues from SubmittingPatches you need to take care of:
- Use git format-patch -M to show the diff, right now the patch just
looks like deleting a bunch of files and adding some new ones which is
very hard to review.
- Split out the bug fixes from the rename, one change per patch.
- Submit in the format specified in SubmittingPatches, not as an
attachment.
> * The patch is renaming tps65023-regulator.c to tps6502x-regulator.c
> (and edits the corresponding Kconfig/Makefile) since it now handles
> both tps65020 and tps65023. Is this allowed or is the Kconfig and
> Makefile files holy or something?
That's fine but you need to take care of any users.
> * checkpatch.pl is showing two warnings about lines over 80
> characters, but this is not really truth. The lines is splitted up so
> it should not complain. Please take a look.
If you think there's a bug in checkpatch please tell the checkpatch
maintainers.
prev parent reply other threads:[~2011-07-26 8:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAM8FrKJ2LAhjvDO9jMZN-D1Sfx=PUuVjMZXBE-E581qdJGxvug@mail.gmail.com>
2011-07-25 22:03 ` regulator: tps65020 support Marcus Folkesson
2011-07-26 8:50 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110726085043.GA7285@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=marcus.folkesson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox