From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751861Ab1G0Efk (ORCPT ); Wed, 27 Jul 2011 00:35:40 -0400 Received: from oproxy7-pub.bluehost.com ([67.222.55.9]:44268 "HELO oproxy7-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750840Ab1G0Efj convert rfc822-to-8bit (ORCPT ); Wed, 27 Jul 2011 00:35:39 -0400 Date: Tue, 26 Jul 2011 21:35:36 -0700 From: Randy Dunlap To: Arnaud Lacombe Cc: Michal Marek , =?ISO-8859-1?Q?Am=E9rico?= Wang , linux-kbuild@vger.kernel.org, sam@ravnborg.org, linux-kernel@vger.kernel.org, plagnioj@jcrosoft.com Subject: Re: [RFC][PATCH 1/2] kconfig: Introduce KCONFIG(), KCONFIG_BUILTIN() and KCONFIG_MODULE() Message-Id: <20110726213536.1f56f0e3.rdunlap@xenotime.net> In-Reply-To: References: <4E1D9C25.8080300@suse.cz> <1311634718-32588-1-git-send-email-mmarek@suse.cz> <4E2EBF63.8050208@suse.cz> <20110726080443.62196869.rdunlap@xenotime.net> <4E2F0735.1070403@suse.cz> <20110726112824.b357c756.rdunlap@xenotime.net> Organization: YPO4 X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT X-Identified-User: {1807:box742.bluehost.com:xenotime:xenotime.net} {sentby:smtp auth 50.53.38.135 authed with rdunlap@xenotime.net} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Jul 2011 20:42:04 -0400 Arnaud Lacombe wrote: > Hi, > > On Tue, Jul 26, 2011 at 2:48 PM, Arnaud Lacombe wrote: > > Hi, > > > > On Tue, Jul 26, 2011 at 2:28 PM, Randy Dunlap wrote: > >> On Tue, 26 Jul 2011 20:28:05 +0200 Michal Marek wrote: > >> > >>> Dne 26.7.2011 17:04, Randy Dunlap napsal(a): > >>> > On Tue, 26 Jul 2011 15:21:39 +0200 Michal Marek wrote: > >>> >> On 26.7.2011 15:01, Américo Wang wrote: > >>> >>> BTW, the name KCONFIG(CONFIG_NUMA) seems ugly. > >>> >> > >>> >> Suggest a better one :). The proposals so far: > >>> >> config_is_numa() (breaks grep) > >>> > > >>> > explain, please. > >>> > >>> If you grep for CONFIG_FOO usage, you'll miss this alternate syntax. > >>> > >> > >> Ack. > >> > >>> > >>> >> CONFIGURED(CONFIG_NUMA) > >>> >> ENABLED(CONFIG_NUMA) > >>> >> KCONFIG(CONFIG_NUMA) > >>> > > >>> > CONFIG(NUMA) || CONFIG(NUMA_BUILTIN) || CONFIG(NUMA_MODULE) > >>> > >>> same problem. > >> > >> Yes, I sorta got that after I sent the email. > >> > >> I guess I prefer your ENABLED() syntax then. > >> > > we need to be careful about namespace pollution/collision. > > > For the sake of having numbers: > > % git grep -w ENABLED . | wc -l > 116 > % git grep -w CONFIGURED . | wc -l > 11 > % git grep -w KCONFIG . | wc -l > 1 OK. Then I would go back to a predicate like the original patch had, e.g.: IS_ENABLED(CONFIG_NUMA) I think that using KCONFIG(CONFIG_NUMA) is klunky (a highly technical term). But Michal can do whatever he likes. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***