Re: [PATCH 3/8] ext4: Warn if direct reclaim tries to writeback pages

Johannes Weiner
2011-08-03T11:06:54Z

On Wed, Aug 03, 2011 at 12:58:19PM +0200, Johannes Weiner wrote:
> On Thu, Jul 21, 2011 at 05:28:45PM +0100, Mel Gorman wrote:
> > Direct reclaim should never writeback pages. Warn if an attempt
> > is made.
> >
> > Signed-off-by: Mel Gorman <mgorman@suse.de>
>
> Acked-by: Johannes Weiner <jweiner@redhat.com>

Oops, too fast.

Shouldn't the WARN_ON() be at the top of the function, rather than
just warn when the write is deferred due to delalloc?