The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Will Newton <will.newton@gmail.com>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
	stable@kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [stable] [PATCH] bitops: Use volatile in generic atomic bitops.
Date: Wed, 27 Jul 2011 09:15:42 -0700	[thread overview]
Message-ID: <20110727161542.GA20238@kroah.com> (raw)
In-Reply-To: <CAFbHwiQaYeQSwRykhKp57rQ8xLKSst9MXF7YJoQjEm0V+WN4Qw@mail.gmail.com>

On Wed, Jul 27, 2011 at 01:21:19PM +0100, Will Newton wrote:
> The generic atomic bitops currently explicitly cast away the
> volatile from the pointer passed to them. This will allow the
> access to the bitfield to happen outside of the critical section
> thus making the bitops no longer interrupt-safe. Remove this cast
> and add a volatile keyword to make sure all accesses to the
> bitfield happen inside the critical section.
> 
> Signed-off-by: Will Newton <will.newton@imgtec.com>
> ---
>  include/asm-generic/bitops/atomic.h |   12 ++++++------
>  1 files changed, 6 insertions(+), 6 deletions(-)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>

      parent reply	other threads:[~2011-07-27 16:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-27 12:21 [PATCH] bitops: Use volatile in generic atomic bitops Will Newton
2011-07-27 12:55 ` Arnd Bergmann
2011-07-27 13:09   ` Will Newton
2011-07-27 14:28     ` Arnd Bergmann
2011-07-27 14:32       ` Will Newton
2011-07-27 15:22         ` Arnd Bergmann
2011-07-27 15:59           ` Will Newton
2011-07-27 16:15 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110727161542.GA20238@kroah.com \
    --to=greg@kroah.com \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@kernel.org \
    --cc=will.newton@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox