Re: [PATCH 4/8] coredump_wait: don't call complete_vfork_done()

Matt Fleming
2011-07-29T15:26:23Z

On Fri, 2011-07-29 at 16:25 +0200, Oleg Nesterov wrote:
>
> Please note that if ->vfork_done != NULL, then ->real_parent shares
> ->mm with us, by definition of CLONE_VFORK.
>
> In this case, with or without this patch, the parent was already
> killed by zap_threads(). It can never do wait() or something else.
>
> However. before 3/8, it was necessary to wakeup the TASK_UNINTERRUPTIBLE
> parent, otherwise we deadlock. Once again, it can't do anything,
> it will die immediately because of fatal_signal_pending().

D'oh, yes. I see now, thanks!