Re: [PATCH 0/8] make vfork killable/restartable/traceable

Oleg Nesterov
2011-07-28T15:01:14Z

On 07/28, Oleg Nesterov wrote:
>
> On 07/27, Linus Torvalds wrote:
> >
> > I *suspect* that the killable() thing could be done more nicely by
> > moving the vfork_completion into the parent instead, and maybe the
> > vfork cleanup could just use
> > "complete(&task->parent->vfork_completion);" instead
>
> I thought about moving the "vfork_done" thing (in some form) from
> child to parent. So far I do not see a clean solution.

Just in case...

We can also do

- struct completion *vfork_done;
+ struct completion vfork_done;

in struct task_struct. This can really simplify these changes.
But we still need to get/put the child, and this bloats task_struct.

Oleg.