Re: [PATCH 4/8] coredump_wait: don't call complete_vfork_done()

Matt Fleming
2011-07-29T13:02:47Z

On Wed, 2011-07-27 at 18:33 +0200, Oleg Nesterov wrote:
> Now that CLONE_VFORK is killable, coredump_wait() no longer needs
> complete_vfork_done(). zap_threads() should find and kill all tasks
> with the same ->mm, this includes our parent if ->vfork_done is set.
>
> mm_release() becomes the only caller, unexport complete_vfork_done().
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>

Isn't there a subtle change in user-visible behaviour regarding wait()
with this patch?

Before the patch, if a child dumps its core it will wakeup the parent
which can read the status of the child via wait(), whereas with this
patch applied the parent will actually be killed along with the child.

I'm not trying to say which behaviour I think is the correct one, just
that because it is a user-visible change and it is maybe worth a bit
more discussion in the changelog?