From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755042Ab1G1IXH (ORCPT ); Thu, 28 Jul 2011 04:23:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24014 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754263Ab1G1IXB (ORCPT ); Thu, 28 Jul 2011 04:23:01 -0400 Date: Thu, 28 Jul 2011 10:24:26 +0200 From: Stanislaw Gruszka To: Andi Kleen Cc: gregkh@suse.de, herton.krzesinski@canonical.com, gengor@gentoo.org, donald.h.fry@intel.com, wey-yi.w.guy@intel.com, ak@linux.intel.com, linux-kernel@vger.kernel.org, stable@kernel.org, tim.bird@am.sony.com Subject: Re: [PATCH] [64/99] Revert "iwlagn: Support new 5000 microcode." Message-ID: <20110728082425.GA2207@redhat.com> References: <20110727247.325703029@firstfloor.org> <20110727214903.75C262403FF@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110727214903.75C262403FF@tassilo.jf.intel.com> User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 27, 2011 at 02:49:03PM -0700, Andi Kleen wrote: > 2.6.35-longterm review patch. If anyone has any objections, please let me know. > > ------------------ > This reverts commit 6f63415fc1b690cb50c2ad48ba6e9e6e88e271b4. > > It turns out this is not what we want to have happen for the .32 and > .33-longterm kernels as it does not work properly at all. Hmm, it does not work on .32 and .33 because they do not contain the commit (which 2.6.35 has): commit dd7a2509b3a79b290730a9c6a784bf03fedabb9a Author: Johannes Berg Date: Wed Apr 28 23:33:10 2010 -0700 iwlagn: implement loading a new firmware file type > This was reported by Gentoo, Arch, and Canonical developers as causing > problems for their users: > https://bugs.archlinux.org/task/24302 This is a bug about 2.6.32. > http://bugs.gentoo.org/show_bug.cgi?id=359445 This looks like problem when only 8.83.5 (v5) firmware is available on the system, but kernel is old and support only v2 version. This should be solved by providing both old 8.24.2 (v2) and new 8.83.5 (v5) firmware blobs in one package. > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/796336 Also 2.6.32 case. There could be reasons for this change, but I do not see them here. Stanislaw