From: Tejun Heo <tj@kernel.org>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Jens Axboe <jaxboe@fusionio.com>, Karel Zak <kzak@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] loop: add management interface for on-demand device allocation
Date: Thu, 28 Jul 2011 12:17:55 +0200 [thread overview]
Message-ID: <20110728101755.GH2622@htj.dyndns.org> (raw)
In-Reply-To: <1311681033.1325.4.camel@mop>
Hello, Kay.
On Tue, Jul 26, 2011 at 01:50:30PM +0200, Kay Sievers wrote:
> From: Kay Sievers <kay.sievers@vrfy.org>
> Subject: loop: add management interface for on-demand device allocation
>
> Loop devices today have a fixed pre-allocated number of usually 8.
> The number can only be changed at init time. To find a free device
> to use, /dev/loop%i needs to be scanned and all devices need to be
> opened.
It generally looks good to me but I really hope it were split into
multiple patches. I think it's a bit too big and doing too many
different things. Can you please split it up?
> +static int loop_lookup(struct loop_device **lo, int nr);
> +static int loop_add(struct loop_device **lo, int nr);
Also, can't these return loop_device * and ERR_PTR() value on errors?
Thanks.
--
tejun
next prev parent reply other threads:[~2011-07-28 10:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-26 11:50 [PATCH] loop: add management interface for on-demand device allocation Kay Sievers
2011-07-28 10:17 ` Tejun Heo [this message]
2011-07-28 11:18 ` Kay Sievers
2011-07-30 19:03 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110728101755.GH2622@htj.dyndns.org \
--to=tj@kernel.org \
--cc=jaxboe@fusionio.com \
--cc=kay.sievers@vrfy.org \
--cc=kzak@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox