From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
David Miller <davem@davemloft.net>,
Chris Metcalf <cmetcalf@tilera.com>,
Guan Xuetao <gxt@mprc.pku.edu.cn>,
Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>,
Mike Frysinger <vapier@gentoo.org>,
Ralf Baechle <ralf@linux-mips.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Russell King <linux@arm.linux.org.uk>,
Paul Mackerras <paulus@samba.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Paul Mundt <lethal@linux-sh.org>
Subject: Re: [PATCH 0/3] rcu: Fix some rcu uses in extended quiescent state
Date: Thu, 28 Jul 2011 13:56:00 -0700 [thread overview]
Message-ID: <20110728205600.GU2403@linux.vnet.ibm.com> (raw)
In-Reply-To: <20110715234154.GC6590@somewhere>
On Sat, Jul 16, 2011 at 01:41:56AM +0200, Frederic Weisbecker wrote:
> On Fri, Jul 15, 2011 at 04:32:03PM -0700, Paul E. McKenney wrote:
> > On Mon, Jul 11, 2011 at 10:34:29PM +0200, Frederic Weisbecker wrote:
> > > Hi,
> > >
> > > First patch lays the ground to fix rcu uses in dyntick idle mode
> > > by splitting rcu extended qs state logic from tick nohz one.
> > >
> > > The rest fixes the misuses that RCU has detected for me in x86.
> >
> > These look good to me -- I have queued them and will try testing
> > them out.
> >
> > > I'll try to fix those Paul has detected in PowerPc.
> >
> > Looking forward to that one as well. ;-)
> >
> > It would be really cool if this approach could serve as RCU's idle-CPU
> > detection regardless of whether or not CONFIG_NO_HZ was set. For one
> > thing, this would simplify the RCU code that treats idle tasks as extended
> > quiescent states. Except during boot time. :-/
>
> For that we could just build rcu_enter_nohz() things on CONFIG_NO_HZ || CONFIG_PROVE_RCU.
Actually, it would be really cool if RCU could just rely on those
callbacks to detect idle regardless of the configuration. Might not
be practical, but it would be nice. ;-)
Thanx, Paul
> > > Frederic Weisbecker (3):
> > > nohz: Split extended quiescent state handling from nohz switch
> > > x86: Enter rcu extended qs after idle notifier call
> > > x86: Call idle notifier after irq_enter()
> > >
> > > arch/arm/kernel/process.c | 4 +-
> > > arch/avr32/kernel/process.c | 4 +-
> > > arch/blackfin/kernel/process.c | 4 +-
> > > arch/microblaze/kernel/process.c | 4 +-
> > > arch/mips/kernel/process.c | 4 +-
> > > arch/powerpc/kernel/idle.c | 4 +-
> > > arch/powerpc/platforms/iseries/setup.c | 8 +++---
> > > arch/s390/kernel/process.c | 4 +-
> > > arch/sh/kernel/idle.c | 2 +-
> > > arch/sparc/kernel/process_64.c | 4 +-
> > > arch/tile/kernel/process.c | 4 +-
> > > arch/um/kernel/process.c | 4 +-
> > > arch/unicore32/kernel/process.c | 4 +-
> > > arch/x86/kernel/apic/apic.c | 6 ++--
> > > arch/x86/kernel/apic/io_apic.c | 2 +-
> > > arch/x86/kernel/cpu/mcheck/mce.c | 2 +-
> > > arch/x86/kernel/cpu/mcheck/therm_throt.c | 2 +-
> > > arch/x86/kernel/cpu/mcheck/threshold.c | 2 +-
> > > arch/x86/kernel/irq.c | 6 ++--
> > > arch/x86/kernel/process_32.c | 4 +-
> > > arch/x86/kernel/process_64.c | 5 ++++
> > > include/linux/tick.h | 10 +++++--
> > > kernel/time/tick-sched.c | 36 ++++++++++++++++++++++++++---
> > > 23 files changed, 83 insertions(+), 46 deletions(-)
> > >
> > > --
> > > 1.7.5.4
> > >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2011-07-28 20:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 20:34 [PATCH 0/3] rcu: Fix some rcu uses in extended quiescent state Frederic Weisbecker
2011-07-11 20:34 ` [PATCH 1/3] nohz: Split extended quiescent state handling from nohz switch Frederic Weisbecker
2011-07-11 20:34 ` [PATCH 2/3] x86: Enter rcu extended qs after idle notifier call Frederic Weisbecker
2011-07-11 20:34 ` [PATCH 3/3] x86: Call idle notifier after irq_enter() Frederic Weisbecker
2011-07-15 23:32 ` [PATCH 0/3] rcu: Fix some rcu uses in extended quiescent state Paul E. McKenney
2011-07-15 23:41 ` Frederic Weisbecker
2011-07-28 20:56 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110728205600.GU2403@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=cmetcalf@tilera.com \
--cc=davem@davemloft.net \
--cc=fweisbec@gmail.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=hans-christian.egtvedt@atmel.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox