From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Marcus Folkesson <marcus.folkesson@gmail.com>
Cc: Liam Girdwood <lrg@ti.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] regulator: tps65023: Added support for the similiar TPS65020 chip
Date: Fri, 29 Jul 2011 15:03:42 +0100 [thread overview]
Message-ID: <20110729140342.GB19118@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAM8FrKL4-hn2rrazsCLrRoVY5zVkgR8A245ScfS48=O41jtffg@mail.gmail.com>
On Fri, Jul 29, 2011 at 03:08:54PM +0200, Marcus Folkesson wrote:
> 2011/7/29 Mark Brown <broonie@opensource.wolfsonmicro.com>:
> > On Wed, Jul 27, 2011 at 12:32:47PM +0200, Marcus Folkesson wrote:
> >> +static struct tps_driver_data tps65020_drv_data = {
> >> + .info = (struct tps_info *) tps65020_regs,
> > Why do you need the cast here? I see it's in the original driver too
> > but it looks like something that should be fixed.
> I also thought about the line, It's only for avoiding warnings from gcc.
> But I don't really understand why gcc is warning.
> gcc output: "warning: initialization discards qualifiers from pointer
> target type".
It's complaining because the declaration of tps65020_regs doesn't match
up with that of .info. Probably the struct member needs to be a const
pointer.
next prev parent reply other threads:[~2011-07-29 14:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 10:32 [PATCH 0/3] regulator: tps65023: TPS65020 support and bug fixes Marcus Folkesson
2011-07-27 10:32 ` [PATCH 1/3] regulator: tps65023: Fixes i2c configuration issues Marcus Folkesson
2011-07-27 11:09 ` Mark Brown
2011-07-27 10:32 ` [PATCH 2/3] regulator: tps65023: Setting correct core regulator for tps65021 Marcus Folkesson
2011-07-27 11:07 ` Mark Brown
2011-07-27 18:12 ` Marcus Folkesson
2011-07-29 12:33 ` Mark Brown
2011-07-29 19:59 ` Marcus Folkesson
2011-08-01 6:14 ` Mark Brown
2011-07-27 10:32 ` [PATCH 3/3] regulator: tps65023: Added support for the similiar TPS65020 chip Marcus Folkesson
2011-07-29 12:34 ` Mark Brown
2011-07-29 13:08 ` Marcus Folkesson
2011-07-29 14:03 ` Mark Brown [this message]
2011-07-29 20:02 ` Marcus Folkesson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110729140342.GB19118@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=marcus.folkesson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox