public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org,
	Kukjin Kim <kgene.kim@samsung.com>
Subject: Re: [PATCH] cpufreq: Fix build of s3c64xx cpufreq driver for header change
Date: Fri, 29 Jul 2011 10:48:02 -0400	[thread overview]
Message-ID: <20110729144802.GB1422@redhat.com> (raw)
In-Reply-To: <1311949618-919-1-git-send-email-broonie@opensource.wolfsonmicro.com>

On Fri, Jul 29, 2011 at 03:26:58PM +0100, Mark Brown wrote:
 > Some header change has removed an implicit include of module.h, breaking
 > the build due to the use of THIS_MODULE. Fix that.

is this dependant on the module.h changes that just got merged in -next
from Paul Gortmaker ?  If so, it should probably get merged as part of that set.

	Dave 

 > Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
 > ---
 >  drivers/cpufreq/s3c64xx-cpufreq.c |    1 +
 >  1 files changed, 1 insertions(+), 0 deletions(-)
 > 
 > diff --git a/drivers/cpufreq/s3c64xx-cpufreq.c b/drivers/cpufreq/s3c64xx-cpufreq.c
 > index b8d1d20..3475f65 100644
 > --- a/drivers/cpufreq/s3c64xx-cpufreq.c
 > +++ b/drivers/cpufreq/s3c64xx-cpufreq.c
 > @@ -15,6 +15,7 @@
 >  #include <linux/clk.h>
 >  #include <linux/err.h>
 >  #include <linux/regulator/consumer.h>
 > +#include <linux/module.h>
 >  
 >  static struct clk *armclk;
 >  static struct regulator *vddarm;
 > -- 
 > 1.7.5.4


  reply	other threads:[~2011-07-29 14:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-29 14:26 [PATCH] cpufreq: Fix build of s3c64xx cpufreq driver for header change Mark Brown
2011-07-29 14:48 ` Dave Jones [this message]
2011-07-29 15:01   ` Mark Brown
2011-07-29 15:08     ` Dave Jones
2011-07-29 15:13       ` Mark Brown
2011-07-29 15:16         ` Dave Jones
  -- strict thread matches above, loose matches on Subject: below --
2011-07-29 15:19 Mark Brown
2011-07-30 17:44 ` Paul Gortmaker
2011-08-01  0:29   ` Mark Brown
2011-08-02  4:38     ` Paul Gortmaker
2011-08-03  5:35       ` Mark Brown
2011-08-03 15:28         ` Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110729144802.GB1422@redhat.com \
    --to=davej@redhat.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=cpufreq@vger.kernel.org \
    --cc=kgene.kim@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox