From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751294Ab1G2PI7 (ORCPT ); Fri, 29 Jul 2011 11:08:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27290 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750828Ab1G2PI6 (ORCPT ); Fri, 29 Jul 2011 11:08:58 -0400 Date: Fri, 29 Jul 2011 11:08:51 -0400 From: Dave Jones To: Mark Brown Cc: linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org, Kukjin Kim Subject: Re: [PATCH] cpufreq: Fix build of s3c64xx cpufreq driver for header change Message-ID: <20110729150851.GA9156@redhat.com> Mail-Followup-To: Dave Jones , Mark Brown , linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org, Kukjin Kim References: <1311949618-919-1-git-send-email-broonie@opensource.wolfsonmicro.com> <20110729144802.GB1422@redhat.com> <20110729150144.GC19118@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110729150144.GC19118@opensource.wolfsonmicro.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 29, 2011 at 04:01:44PM +0100, Mark Brown wrote: > On Fri, Jul 29, 2011 at 10:48:02AM -0400, Dave Jones wrote: > > On Fri, Jul 29, 2011 at 03:26:58PM +0100, Mark Brown wrote: > > > Some header change has removed an implicit include of module.h, breaking > > > the build due to the use of THIS_MODULE. Fix that. > > > is this dependant on the module.h changes that just got merged in -next > > from Paul Gortmaker ? If so, it should probably get merged as part of that set. > > Possibly, but there were a bunch of other failures in the Samsung > specific stuff not related to module.h which appeared today. I did run > into another non-samsung module.h failure, though. Mostly I was just > surprised stuff like this was showing up so late in the merge window, I > didn't spend a lot of time investigating what broke. wait, confused. Were you building Linus' tree, or -next ? Dave