* Re: [PATCH] perf: add --symfs option to perf annotate
2011-07-29 23:20 [PATCH] perf: add --symfs option to perf annotate Stephane Eranian
@ 2011-07-29 23:28 ` David Ahern
2011-08-18 20:13 ` [tip:perf/core] perf annotate: Add --symfs option tip-bot for Stephane Eranian
1 sibling, 0 replies; 3+ messages in thread
From: David Ahern @ 2011-07-29 23:28 UTC (permalink / raw)
To: Stephane Eranian, acme; +Cc: linux-kernel, mingo, peterz
On 07/29/2011 05:20 PM, Stephane Eranian wrote:
>
> If you have --symfs in perf report, then you also need it
> for perf annotate. This allows off-box assembly level analysis
> of perf.data samples.
>
> This patch complements:
>
> commit ec5761eab318e50e69fcf8e63e9edaef5949c067
> Author: David Ahern <daahern@cisco.com>
> Date: Thu Dec 9 13:27:07 2010 -0700
>
> perf symbols: Add symfs option for off-box analysis using specified tree
>
> Signed-off-by: Stephane Eranian <eranian@google.com>
> ---
>
> diff --git a/tools/perf/Documentation/perf-annotate.txt b/tools/perf/Documentation/perf-annotate.txt
> index 85c5f02..15919dd 100644
> --- a/tools/perf/Documentation/perf-annotate.txt
> +++ b/tools/perf/Documentation/perf-annotate.txt
> @@ -72,6 +72,9 @@ OPTIONS
> CPUs are specified with -: 0-2. Default is to report samples on all
> CPUs.
>
> +--symfs=<directory>::
> + Look for files with symbols relative to this directory.
> +
> SEE ALSO
> --------
> linkperf:perf-record[1], linkperf:perf-report[1]
> diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
> index 555aefd..1605fbe 100644
> --- a/tools/perf/builtin-annotate.c
> +++ b/tools/perf/builtin-annotate.c
> @@ -267,6 +267,8 @@ static const struct option options[] = {
> OPT_BOOLEAN('P', "full-paths", &full_paths,
> "Don't shorten the displayed pathnames"),
> OPT_STRING('c', "cpu", &cpu_list, "cpu", "list of cpus to profile"),
> + OPT_STRING(0, "symfs", &symbol_conf.symfs, "directory",
> + "Look for files with symbols relative to this directory"),
> OPT_END()
> };
>
Acked-by: David Ahern <daahern@cisco.com>
Nice to see others making use of that option.
David
^ permalink raw reply [flat|nested] 3+ messages in thread* [tip:perf/core] perf annotate: Add --symfs option
2011-07-29 23:20 [PATCH] perf: add --symfs option to perf annotate Stephane Eranian
2011-07-29 23:28 ` David Ahern
@ 2011-08-18 20:13 ` tip-bot for Stephane Eranian
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Stephane Eranian @ 2011-08-18 20:13 UTC (permalink / raw)
To: linux-tip-commits
Cc: acme, linux-kernel, eranian, hpa, mingo, peterz, tglx, daahern,
mingo
Commit-ID: e71a059832753a8834a5a5080366879954ccdc4d
Gitweb: http://git.kernel.org/tip/e71a059832753a8834a5a5080366879954ccdc4d
Author: Stephane Eranian <eranian@google.com>
AuthorDate: Sat, 30 Jul 2011 01:20:40 +0200
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 18 Aug 2011 07:40:34 -0300
perf annotate: Add --symfs option
If you have --symfs in perf report, then you also need it for perf
annotate. This allows off-box assembly level analysis of perf.data
samples.
This patch complements:
commit ec5761eab318e50e69fcf8e63e9edaef5949c067
Author: David Ahern <daahern@cisco.com>
Date: Thu Dec 9 13:27:07 2010 -0700
perf symbols: Add symfs option for off-box analysis using specified tree
Acked-by: David Ahern <daahern@cisco.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: David Ahern <daahern@cisco.com>
Link: http://lkml.kernel.org/r/20110729232040.GA21838@quad
Signed-off-by: Stephane Eranian <eranian@google.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/Documentation/perf-annotate.txt | 3 +++
tools/perf/builtin-annotate.c | 2 ++
2 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/tools/perf/Documentation/perf-annotate.txt b/tools/perf/Documentation/perf-annotate.txt
index 5bc0600..98a31e3 100644
--- a/tools/perf/Documentation/perf-annotate.txt
+++ b/tools/perf/Documentation/perf-annotate.txt
@@ -80,6 +80,9 @@ OPTIONS
Interleave source code with assembly code. Enabled by default,
disable with --no-source.
+--symfs=<directory>::
+ Look for files with symbols relative to this directory.
+
SEE ALSO
--------
linkperf:perf-record[1], linkperf:perf-report[1]
diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
index 5015e04..c5be288 100644
--- a/tools/perf/builtin-annotate.c
+++ b/tools/perf/builtin-annotate.c
@@ -267,6 +267,8 @@ static const struct option options[] = {
OPT_BOOLEAN('P', "full-paths", &full_paths,
"Don't shorten the displayed pathnames"),
OPT_STRING('c', "cpu", &cpu_list, "cpu", "list of cpus to profile"),
+ OPT_STRING(0, "symfs", &symbol_conf.symfs, "directory",
+ "Look for files with symbols relative to this directory"),
OPT_BOOLEAN('0', "source", &symbol_conf.annotate_src,
"Interleave source code with assembly code (default)"),
OPT_BOOLEAN('0', "asm-raw", &symbol_conf.annotate_asm_raw,
^ permalink raw reply related [flat|nested] 3+ messages in thread