From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752316Ab1GaQmh (ORCPT ); Sun, 31 Jul 2011 12:42:37 -0400 Received: from trinity.fluff.org ([89.16.178.74]:42300 "EHLO trinity.fluff.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751784Ab1GaQm3 (ORCPT ); Sun, 31 Jul 2011 12:42:29 -0400 Date: Sun, 31 Jul 2011 17:42:08 +0100 From: Ben Dooks To: Paul Gortmaker Cc: Randy Dunlap , Stephen Rothwell , linux-i2c@vger.kernel.org, akpm , linux-next@vger.kernel.org, LKML , khali@linux-fr.org, ben-linux@fluff.org Subject: Re: [PATCH -next] i2c: i2c-pxa-pci.c needs module.h Message-ID: <20110731164208.GP15795@trinity.fluff.org> References: <20110729173827.716f57ff6e00095a3efc6449@canb.auug.org.au> <20110729211430.6c4830bd.rdunlap@xenotime.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Disclaimer: These are my views alone. X-URL: http://www.fluff.org/ User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: ben@trinity.fluff.org X-SA-Exim-Scanned: No (on trinity.fluff.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 30, 2011 at 03:09:32PM -0400, Paul Gortmaker wrote: > On Sat, Jul 30, 2011 at 12:14 AM, Randy Dunlap wrote: > > From: Randy Dunlap > > > > i2c-pxa-pci.c uses interfaces from linux/module.h, so it should > > include that file.  This fixes build errors. > > Applied to module.h-split, thanks. ok, so I don't need to apply this one? Acked-by: Ben Dooks > P. > > > > > Signed-off-by: Randy Dunlap > > --- > >  drivers/i2c/busses/i2c-pxa-pci.c |    1 + > >  1 file changed, 1 insertion(+) > > > > --- linux-next-20110729.orig/drivers/i2c/busses/i2c-pxa-pci.c > > +++ linux-next-20110729/drivers/i2c/busses/i2c-pxa-pci.c > > @@ -3,6 +3,7 @@ > >  * It does not support slave mode, the register slightly moved. This PCI > >  * device provides three bars, every contains a single I2C controller. > >  */ > > +#include > >  #include > >  #include > >  #include > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-next" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at  http://vger.kernel.org/majordomo-info.html > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-i2c" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Dooks, ben@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear.