From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753272Ab1HAAPh (ORCPT ); Sun, 31 Jul 2011 20:15:37 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:46507 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752756Ab1HAAPa (ORCPT ); Sun, 31 Jul 2011 20:15:30 -0400 Date: Mon, 1 Aug 2011 01:15:24 +0100 From: Mark Brown To: Randy Dunlap Cc: Stephen Rothwell , akpm , linux-next@vger.kernel.org, LKML , Liam Girdwood Subject: Re: [PATCH -next] regulator: aat2870-regulator.c needs module.h Message-ID: <20110801001523.GA20641@opensource.wolfsonmicro.com> References: <20110729173827.716f57ff6e00095a3efc6449@canb.auug.org.au> <20110729211309.92e8b744.rdunlap@xenotime.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110729211309.92e8b744.rdunlap@xenotime.net> X-Cookie: Tomorrow, you can be anywhere. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 29, 2011 at 09:13:09PM -0700, Randy Dunlap wrote: > From: Randy Dunlap > > aat2870-regulator.c needs to include linux/module.h to fix multiple > build errors. Acked-by: Mark Brown but if the breakage isn't in mainline yet to minimize the breaks bisection someone should figure out which tree introduced the change with module.h and either get the fix merged along with that. If neither the module.h change nor the driver is in Linus' tree yet I rather suspect this should go via MFD as I seem to recall that the driver is going in via there. It's not entirely clear to me why this started showing up part way through the merge window :/