From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Francis Moreau <francis.moro@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Don Zickus <dzickus@redhat.com>,
Stephane Eranian <eranian@google.com>,
Ingo Molnar <mingo@elte.hu>, Jiri Slaby <jirislaby@gmail.com>
Subject: Re: v3.0: Weird kernel log message when resuming avout NMI received
Date: Mon, 1 Aug 2011 15:21:02 +0400 [thread overview]
Message-ID: <20110801112102.GQ2209@sun> (raw)
In-Reply-To: <1312196702.2617.445.camel@laptop>
On Mon, Aug 01, 2011 at 01:05:02PM +0200, Peter Zijlstra wrote:
> On Sun, 2011-07-31 at 19:32 +0400, Cyrill Gorcunov wrote:
>
> > > >> I'm seeing those kernel message when resuming:
> > > >>
> > > >> [ 524.973283] Uhhuh. NMI received for unknown reason 3d on CPU 0.
> > > >> [ 524.973288] Do you have a strange power saving mode enabled?
> > > >> [ 524.973289] Dazed and confused, but trying to continue
> > > >>
> > > >> I don't know if it's important or not because the system seems to work
> > > >> after but maybe it worths to report
>
> So I guess the problem is the NMI watchdog and suspend stuff not
> shutting things down properly..
>
> Argh, the PM notifier muck runs before the hotplug notifiers and it
> doesn't avoid hotplug races on its own.. what crap.
>
> something like the below perhaps, compile tested only.. does it work?
>
Thanks a huge, Peter! (I'm CC'ing Jiri as well, he has same issue)
...
> @@ -6809,7 +6810,7 @@ static void __cpuinit perf_event_init_cp
> struct swevent_htable *swhash = &per_cpu(swevent_htable, cpu);
>
> mutex_lock(&swhash->hlist_mutex);
> - if (swhash->hlist_refcount > 0) {
> + if (swhash->hlist_refcount > 0 && !swhash->swevent_hlist) {
Should not there be rcu_dereference(swhash->swevent_hlist)?
> struct swevent_hlist *hlist;
>
> hlist = kzalloc_node(sizeof(*hlist), GFP_KERNEL, cpu_to_node(cpu));
...
Cyrill
next prev parent reply other threads:[~2011-08-01 11:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-31 6:56 v3.0: Weird kernel log message when resuming avout NMI received Francis Moreau
2011-07-31 11:06 ` Cyrill Gorcunov
2011-07-31 11:19 ` Jiri Slaby
2011-07-31 11:26 ` Cyrill Gorcunov
2011-08-02 19:48 ` Don Zickus
2011-08-02 21:00 ` Jiri Slaby
2011-08-03 0:52 ` Donald Zickus II
2011-07-31 15:20 ` Francis Moreau
2011-07-31 15:32 ` Cyrill Gorcunov
2011-08-01 11:05 ` Peter Zijlstra
2011-08-01 11:21 ` Cyrill Gorcunov [this message]
2011-08-01 12:12 ` Peter Zijlstra
2011-08-15 8:37 ` Francis Moreau
2011-08-16 15:07 ` Francis Moreau
2011-08-02 19:52 ` Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110801112102.GQ2209@sun \
--to=gorcunov@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=dzickus@redhat.com \
--cc=eranian@google.com \
--cc=francis.moro@gmail.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox