Re: [PATCH 1/8] cgroups: Add res_counter_write_u64() API

Oleg Nesterov
2011-08-09T15:21:00Z

On 07/29, Frederic Weisbecker wrote:
>
> +void res_counter_write_u64(struct res_counter *counter, int member, u64 val)
> +{
> + unsigned long long *target;
> + unsigned long flags;
> +
> + spin_lock_irqsave(&counter->lock, flags);
> + target = res_counter_member(counter, member);
> + *target = val;
> + spin_unlock_irqrestore(&counter->lock, flags);
> +}

Hmm. Why do we need counter->lock?

OK, probably it is for BITS_PER_LONG < 64. May be it makes sense
to ifdef, just to make the code more understandable.

Oleg.