From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Anuj Aggarwal <anuj.aggarwal@ti.com>, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] regulator: tps65023: Remove num_voltages array
Date: Tue, 2 Aug 2011 16:57:29 +0900 [thread overview]
Message-ID: <20110802075728.GA9553@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1312271310.12639.3.camel@phoenix>
On Tue, Aug 02, 2011 at 03:48:30PM +0800, Axel Lin wrote:
> @@ -519,12 +515,14 @@ static const struct tps_info tps65023_regs[] = {
> .name = "VDCDC2",
> .min_uV = 3300000,
> .max_uV = 3300000,
> + .table_len = 0,
> .fixed = 1,
> },
> {
> .name = "VDCDC3",
> .min_uV = 1800000,
> .max_uV = 1800000,
> + .table_len = 0,
> .fixed = 1,
No need to explicitly set things to zero, it's the default for things
declared static. If this isn't declared static then it should be.
prev parent reply other threads:[~2011-08-02 7:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 7:48 [PATCH] regulator: tps65023: Remove num_voltages array Axel Lin
2011-08-02 7:57 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110802075728.GA9553@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=anuj.aggarwal@ti.com \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox