* [PATCH] regulator: tps65023: Remove num_voltages array
@ 2011-08-02 7:48 Axel Lin
2011-08-02 7:57 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2011-08-02 7:48 UTC (permalink / raw)
To: linux-kernel; +Cc: Anuj Aggarwal, Liam Girdwood, Mark Brown
We can get n_voltages for each regulator from table_len of struct tps_info.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/regulator/tps65023-regulator.c | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/regulator/tps65023-regulator.c b/drivers/regulator/tps65023-regulator.c
index 701a590..dd0c72f 100644
--- a/drivers/regulator/tps65023-regulator.c
+++ b/drivers/regulator/tps65023-regulator.c
@@ -106,10 +106,6 @@ static const u16 LDO2_VSEL_table[] = {
2500, 2800, 3000, 3300,
};
-static unsigned int num_voltages[] = {ARRAY_SIZE(VDCDC1_VSEL_table),
- 0, 0, ARRAY_SIZE(LDO1_VSEL_table),
- ARRAY_SIZE(LDO2_VSEL_table)};
-
/* Regulator specific details */
struct tps_info {
const char *name;
@@ -453,7 +449,7 @@ static int __devinit tps_65023_probe(struct i2c_client *client,
tps->desc[i].name = info->name;
tps->desc[i].id = i;
- tps->desc[i].n_voltages = num_voltages[i];
+ tps->desc[i].n_voltages = info->table_len;
tps->desc[i].ops = (i > TPS65023_DCDC_3 ?
&tps65023_ldo_ops : &tps65023_dcdc_ops);
tps->desc[i].type = REGULATOR_VOLTAGE;
@@ -519,12 +515,14 @@ static const struct tps_info tps65023_regs[] = {
.name = "VDCDC2",
.min_uV = 3300000,
.max_uV = 3300000,
+ .table_len = 0,
.fixed = 1,
},
{
.name = "VDCDC3",
.min_uV = 1800000,
.max_uV = 1800000,
+ .table_len = 0,
.fixed = 1,
},
{
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] regulator: tps65023: Remove num_voltages array
2011-08-02 7:48 [PATCH] regulator: tps65023: Remove num_voltages array Axel Lin
@ 2011-08-02 7:57 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2011-08-02 7:57 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Anuj Aggarwal, Liam Girdwood
On Tue, Aug 02, 2011 at 03:48:30PM +0800, Axel Lin wrote:
> @@ -519,12 +515,14 @@ static const struct tps_info tps65023_regs[] = {
> .name = "VDCDC2",
> .min_uV = 3300000,
> .max_uV = 3300000,
> + .table_len = 0,
> .fixed = 1,
> },
> {
> .name = "VDCDC3",
> .min_uV = 1800000,
> .max_uV = 1800000,
> + .table_len = 0,
> .fixed = 1,
No need to explicitly set things to zero, it's the default for things
declared static. If this isn't declared static then it should be.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-02 7:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-02 7:48 [PATCH] regulator: tps65023: Remove num_voltages array Axel Lin
2011-08-02 7:57 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox