public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Florian Mickler <florian@mickler.org>
To: Dan Carpenter <error27@gmail.com>
Cc: linux-kernel@vger.kernel.org, Tino Keitel <tino.keitel@tikei.de>,
	mchehab@infradead.org
Subject: Re: USB related "unable to handle kernel paging request" in 3.0.0-rc7
Date: Tue, 2 Aug 2011 14:02:15 +0200	[thread overview]
Message-ID: <20110802140215.008ecfa6@schatten.dmk.lab> (raw)
In-Reply-To: <20110802113554.GC4516@shale.localdomain>

On Tue, 2 Aug 2011 14:35:54 +0300
Dan Carpenter <error27@gmail.com> wrote:

> On Tue, Aug 02, 2011 at 12:40:28PM +0200, Florian Mickler wrote:
> > This should fix it. 
> > 
> 
> That's not right.  You should just make .size_of_priv = 20 with a
> comment.

Right. Don't know why I didn't do so right from the start. The thing
is, the buffer has to be seperately allocated from the heap in order
for it to be used as a dma target. 
I probably overlooked that that is what actually happens in
dvb_usb_device_init. Or realized and changed everything accordingly but
forgot the .size_of_priv. ? 

Anyway, that is what you get if you can't actually test what you do. 
(Sorry Tino! The original patch submission had a big fat warning
that it was only compile tested, but that got lost somewhere along
the line...) 

> 
> regards,
> dan carpenter
> 

Thx,
Flo

  parent reply	other threads:[~2011-08-02 12:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-22 19:27 USB related "unable to handle kernel paging request" in 3.0.0-rc7 Tino Keitel
2011-07-25 19:47 ` Maciej Rutecki
2011-08-02  8:54 ` Dan Carpenter
2011-08-02  9:51   ` Florian Mickler
2011-08-02 10:40     ` Florian Mickler
2011-08-02 11:10       ` Florian Mickler
2011-08-02 11:51         ` Florian Mickler
2011-08-02 11:56           ` Dan Carpenter
2011-08-02 11:35       ` Dan Carpenter
2011-08-02 11:40         ` Dan Carpenter
2011-08-02 12:02         ` Florian Mickler [this message]
2011-08-02 12:29 ` [PATCH] [media] vp7045: fix buffer setup Florian Mickler
2011-08-03 19:02   ` Tino Keitel
2011-08-09 20:08     ` Tino Keitel
2011-08-10  9:46       ` Florian Mickler
2011-08-10 10:05       ` Florian Mickler
2011-08-19 16:35         ` Florian Mickler
2011-08-24 16:26           ` Tino Keitel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110802140215.008ecfa6@schatten.dmk.lab \
    --to=florian@mickler.org \
    --cc=error27@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=tino.keitel@tikei.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox