From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755080Ab1HBSzw (ORCPT ); Tue, 2 Aug 2011 14:55:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49026 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755009Ab1HBSzq (ORCPT ); Tue, 2 Aug 2011 14:55:46 -0400 Date: Tue, 2 Aug 2011 14:55:30 -0400 From: Vivek Goyal To: Michael Holzheu Cc: ebiederm@xmission.com, mahesh@linux.vnet.ibm.com, hbabu@us.ibm.com, oomichi@mxs.nes.nec.co.jp, horms@verge.net.au, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org Subject: Re: [patch v2 02/10] kdump: Make kimage_load_crash_segment() weak Message-ID: <20110802185530.GH6399@redhat.com> References: <20110727125504.491183728@linux.vnet.ibm.com> <20110727125807.695225427@linux.vnet.ibm.com> <20110801203143.GH3805@redhat.com> <1312277403.4881.26.camel@br98xy6r> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1312277403.4881.26.camel@br98xy6r> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 02, 2011 at 11:30:03AM +0200, Michael Holzheu wrote: > Hello Vivek, > > On Mon, 2011-08-01 at 16:31 -0400, Vivek Goyal wrote: > > On Wed, Jul 27, 2011 at 02:55:06PM +0200, Michael Holzheu wrote: > > [snip] > > > > --- a/kernel/kexec.c > > > +++ b/kernel/kexec.c > > > @@ -842,8 +842,8 @@ out: > > > return result; > > > } > > > > > > -static int kimage_load_crash_segment(struct kimage *image, > > > - struct kexec_segment *segment) > > > +int __weak kimage_load_crash_segment(struct kimage *image, > > > + struct kexec_segment *segment) > > > > A comment here why we are making it weak should help in increasing > > the code readability. > > What about the following: > > /* > * Load crash segment into memory. Architecture code can override this > * function. E.g. this is necessary for architectures that do not > * create page tables for crashkernel memory. > */ > int __weak kimage_load_crash_segment(struct kimage *image, This looks better. Thanks Vivek