From: Borislav Petkov <bp@amd64.org>
To: Len Brown <lenb@kernel.org>
Cc: Matthew Garrett <mjg@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"davej@redhat.com" <davej@redhat.com>,
"Langsdorf, Mark" <mark.langsdorf@amd.com>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>
Subject: Re: [PATCH 2/5] acpi-cpufreq: Add support for disabling dynamic overclocking
Date: Tue, 2 Aug 2011 22:50:44 +0200 [thread overview]
Message-ID: <20110802205044.GA21330@aftab> (raw)
In-Reply-To: <alpine.LFD.2.02.1108021618190.25237@x980>
On Tue, Aug 02, 2011 at 04:21:16PM -0400, Len Brown wrote:
> While this patch will work and is not invalid, I don't like it.
>
> It advertises a user I/F that suggests that disabling turbo
> is on a per logical processor basis -- but a write to
> any of the attributes will write to every CPU in the system.
>
> Either it should do per-cpu limiting (which, btw doesn't
> work if you use the MISC_ENABLES MSR method in this patch,
> and would instead need to use the PERF_CTL.32 method)
> or there should be a per-system attribute
> that reflects that this knob is per-system.
Agreed with the per-system thing. The reason to disable boosting on
all cores is very simple: nobody has come up with a usecase until now
which needs disabling only a subset of the cores. Also, this way the
implementation is the simplest.
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
next prev parent reply other threads:[~2011-08-02 20:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 17:03 [PATCH 1/5] acpi-cpufreq: Add support for modern AMD CPUs Matthew Garrett
2011-05-17 17:03 ` [PATCH 2/5] acpi-cpufreq: Add support for disabling dynamic overclocking Matthew Garrett
2011-08-02 20:21 ` Len Brown
2011-08-02 20:50 ` Borislav Petkov [this message]
2011-05-17 17:03 ` [PATCH 3/5] ACPI: Add fixups for AMD P-state figures Matthew Garrett
2011-05-17 17:03 ` [PATCH 4/5] cpufreq: Add compatibility hack to powernow-k8 Matthew Garrett
2011-05-17 17:03 ` [PATCH 5/5] cpufreq: Remove support for hardware P-state chips from powernow-k8 Matthew Garrett
2011-05-17 17:35 ` [PATCH 1/5] acpi-cpufreq: Add support for modern AMD CPUs Borislav Petkov
2011-05-17 17:42 ` Matthew Garrett
2011-05-17 18:13 ` Borislav Petkov
2011-05-17 18:17 ` Matthew Garrett
2011-05-19 7:26 ` Andreas Herrmann
2011-08-02 20:18 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110802205044.GA21330@aftab \
--to=bp@amd64.org \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.langsdorf@amd.com \
--cc=mjg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).