From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753514Ab1HBXQ6 (ORCPT ); Tue, 2 Aug 2011 19:16:58 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52562 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753411Ab1HBXQw (ORCPT ); Tue, 2 Aug 2011 19:16:52 -0400 Date: Tue, 2 Aug 2011 16:16:41 -0700 From: Greg KH To: Kay Sievers Cc: Lucas De Marchi , Andrew Morton , "Eric W. Biederman" , Alan Cox , linux-kernel@vger.kernel.org, Nick Piggin , Al Viro , Christoph Hellwig , Stephen Rothwell , David Howells , "Serge E. Hallyn" , Daniel Lezcano , Jiri Slaby , James Morris , neilb@suse.de Subject: Re: [PATCH] sysctl: add support for poll() Message-ID: <20110802231641.GA2598@suse.de> References: <20110602134338.0c56160e@lxorguk.ukuu.org.uk> <20110608151732.2b321b9a.akpm@linux-foundation.org> <1307981153.1449.19.camel@mop> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 03, 2011 at 12:53:33AM +0200, Kay Sievers wrote: > On Tue, Jul 26, 2011 at 04:17, Lucas De Marchi > wrote: > > On Mon, Jun 13, 2011 at 1:05 PM, Kay Sievers wrote: > >> On Thu, 2011-06-09 at 15:16 +0200, Kay Sievers wrote: > >>> On Thu, Jun 9, 2011 at 00:17, Andrew Morton wrote: > >> > >>> > We already have several pollable procfs files, such as > >>> > fs/proc/base.c:mounts_poll() and I think drivers/md has one.  I do > >>> > think that any work in this area should end up with those custom > >>> > make-procfs-pollable hacks being identified and removed. > >>> > >>> For these files we can probably move the event counter into the > >>> seq_file structure, and get rid of the dance to kmalloc it and assign > >>> it to seq_file->private. That might simplify the logic a bit. > >>> > >>> [Adding Neil, to get his opinion of moving 'event' so seq_file and get > >>> rid of the malloc dance] > >> > >> I guess, we could do something like this, which looks quite a bit > >> simpler by moving the poll event counter into the dynamically allocated > >> seq_file structure itself, instead of having private structures > >> allocated on top to just carry the counter (patch is just > >> compile-tested). > > > > Now that this cleanup made its way, could we look again to to the > > pollable sysctl implementation? > > Can we please get support for poll() for /proc/sys files merged? Just > like we do that for /proc already. > > We like to have notifications triggered by the kernel for selected > files in /proc/sys. > > I don't really see any technical reasons to hold this back. Care to resend the patch so we can queue it up for 3.2? thanks, greg k-h