Re: [PATCH] libertas: prioritize usb8388_v5.bin firmware on OLPC machines

[Andres Salomon <dilinger@queued.net>]

On Mon, 01 Aug 2011 16:20:07 -0500
Dan Williams <dcbw@redhat.com> wrote:

> On Mon, 2011-08-01 at 11:25 -0700, Andres Salomon wrote:
> > On Mon, 01 Aug 2011 12:17:23 -0500
> > Dan Williams <dcbw@redhat.com> wrote:
> > 
> > > On Sun, 2011-07-31 at 13:59 +0100, Daniel Drake wrote:
> > > > On 31 July 2011 08:05, Andres Salomon <dilinger@queued.net>
> > > > wrote:
> > > > > Note: I've not tested this out yet on an XO-1.  I'll do that
> > > > > after some feedback regarding the matching linux-firmware pull
> > > > > request.  This should address dsd's concern about changing the
> > > > > loading order of the firmware.
> > > > 
> > > > That indeed was a concern, but only until Dan Williams and Chris
> > > > pointed out that OLPC is the only usb8388 user. With that in
> > > > mind, I am in agreement with them that simply putting
> > > > usb8388_olpc_v5.bin (or whatever name is chosen) at the top of
> > > > the firmware loading list is the best option.
> > > 
> > > Yeah, patches for that would be immediately acked.
> > > 
> > 
> > What's your opinion on overwriting usb8388_v5.bin with OLPC's
> > version, versus having both a usb8388_v5.bin and a
> > usb8388_olpc_v5.bin?
> 
> I'd slightly prefer to keep them separate, but I don't really care
> that much.  Whatever you'd like to do here is fine.
> 

Alright, since people seem to prefer keeping it around, I'll redo the
pull request (and libertas patch) to do that.