* regulator: max8952 init a mutex but never use it @ 2011-08-02 12:16 Axel Lin 2011-08-02 13:41 ` Liam Girdwood 0 siblings, 1 reply; 5+ messages in thread From: Axel Lin @ 2011-08-02 12:16 UTC (permalink / raw) To: linux-kernel; +Cc: MyungJoo Ham, Liam Girdwood, Mark Brown hi, The max8952 regulator driver init a mutex but never use it, do we really need the mutex? Or should we just remove it? Regards, Axel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: regulator: max8952 init a mutex but never use it 2011-08-02 12:16 regulator: max8952 init a mutex but never use it Axel Lin @ 2011-08-02 13:41 ` Liam Girdwood 2011-08-03 0:58 ` [PATCH] regulator: max8952: removed unused mutex MyungJoo Ham 0 siblings, 1 reply; 5+ messages in thread From: Liam Girdwood @ 2011-08-02 13:41 UTC (permalink / raw) To: Axel Lin; +Cc: linux-kernel@vger.kernel.org, MyungJoo Ham, Mark Brown On 02/08/11 13:16, Axel Lin wrote: > hi, > The max8952 regulator driver init a mutex but never use it, > do we really need the mutex? Or should we just remove it? > It can be removed if it is not being used anywhere. Liam ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] regulator: max8952: removed unused mutex. 2011-08-02 13:41 ` Liam Girdwood @ 2011-08-03 0:58 ` MyungJoo Ham 2011-08-03 4:38 ` Mark Brown 2011-08-08 16:40 ` Liam Girdwood 0 siblings, 2 replies; 5+ messages in thread From: MyungJoo Ham @ 2011-08-03 0:58 UTC (permalink / raw) To: Axel Lin Cc: linux-kernel, MyungJoo Ham, Mark Brown, myungjoo.ham, Liam Girdwood This patch removes a mutex that is never used in the driver. Reported-by: Axel Lin Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com> --- drivers/regulator/max8952.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/max8952.c b/drivers/regulator/max8952.c index daff7fd..2fa8a81 100644 --- a/drivers/regulator/max8952.c +++ b/drivers/regulator/max8952.c @@ -26,7 +26,6 @@ #include <linux/platform_device.h> #include <linux/regulator/driver.h> #include <linux/regulator/max8952.h> -#include <linux/mutex.h> #include <linux/gpio.h> #include <linux/io.h> #include <linux/slab.h> @@ -47,7 +46,6 @@ enum { struct max8952_data { struct i2c_client *client; struct device *dev; - struct mutex mutex; struct max8952_platform_data *pdata; struct regulator_dev *rdev; @@ -208,7 +206,6 @@ static int __devinit max8952_pmic_probe(struct i2c_client *client, max8952->client = client; max8952->dev = &client->dev; max8952->pdata = pdata; - mutex_init(&max8952->mutex); max8952->rdev = regulator_register(®ulator, max8952->dev, &pdata->reg_data, max8952); -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] regulator: max8952: removed unused mutex. 2011-08-03 0:58 ` [PATCH] regulator: max8952: removed unused mutex MyungJoo Ham @ 2011-08-03 4:38 ` Mark Brown 2011-08-08 16:40 ` Liam Girdwood 1 sibling, 0 replies; 5+ messages in thread From: Mark Brown @ 2011-08-03 4:38 UTC (permalink / raw) To: MyungJoo Ham; +Cc: Axel Lin, linux-kernel, myungjoo.ham, Liam Girdwood On Wed, Aug 03, 2011 at 09:58:03AM +0900, MyungJoo Ham wrote: > This patch removes a mutex that is never used in the driver. > > Reported-by: Axel Lin > Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] regulator: max8952: removed unused mutex. 2011-08-03 0:58 ` [PATCH] regulator: max8952: removed unused mutex MyungJoo Ham 2011-08-03 4:38 ` Mark Brown @ 2011-08-08 16:40 ` Liam Girdwood 1 sibling, 0 replies; 5+ messages in thread From: Liam Girdwood @ 2011-08-08 16:40 UTC (permalink / raw) To: MyungJoo Ham Cc: Axel Lin, linux-kernel, Mark Brown, myungjoo.ham, Liam Girdwood On Wed, 2011-08-03 at 09:58 +0900, MyungJoo Ham wrote: > This patch removes a mutex that is never used in the driver. > > Reported-by: Axel Lin > Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com> > --- > drivers/regulator/max8952.c | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/drivers/regulator/max8952.c b/drivers/regulator/max8952.c > index daff7fd..2fa8a81 100644 > --- a/drivers/regulator/max8952.c > +++ b/drivers/regulator/max8952.c > @@ -26,7 +26,6 @@ > #include <linux/platform_device.h> > #include <linux/regulator/driver.h> > #include <linux/regulator/max8952.h> > -#include <linux/mutex.h> > #include <linux/gpio.h> > #include <linux/io.h> > #include <linux/slab.h> > @@ -47,7 +46,6 @@ enum { > struct max8952_data { > struct i2c_client *client; > struct device *dev; > - struct mutex mutex; > struct max8952_platform_data *pdata; > struct regulator_dev *rdev; > > @@ -208,7 +206,6 @@ static int __devinit max8952_pmic_probe(struct i2c_client *client, > max8952->client = client; > max8952->dev = &client->dev; > max8952->pdata = pdata; > - mutex_init(&max8952->mutex); > > max8952->rdev = regulator_register(®ulator, max8952->dev, > &pdata->reg_data, max8952); Applied. Thanks Liam ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-08-08 16:40 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-08-02 12:16 regulator: max8952 init a mutex but never use it Axel Lin 2011-08-02 13:41 ` Liam Girdwood 2011-08-03 0:58 ` [PATCH] regulator: max8952: removed unused mutex MyungJoo Ham 2011-08-03 4:38 ` Mark Brown 2011-08-08 16:40 ` Liam Girdwood
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox