From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753712Ab1HCN6s (ORCPT ); Wed, 3 Aug 2011 09:58:48 -0400 Received: from cantor2.suse.de ([195.135.220.15]:35668 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752943Ab1HCN6n (ORCPT ); Wed, 3 Aug 2011 09:58:43 -0400 Date: Wed, 3 Aug 2011 14:58:39 +0100 From: Mel Gorman To: Johannes Weiner Cc: Linux-MM , LKML , XFS , Dave Chinner , Christoph Hellwig , Wu Fengguang , Jan Kara , Rik van Riel , Minchan Kim Subject: Re: [PATCH 8/8] mm: vmscan: Do not writeback filesystem pages from kswapd Message-ID: <20110803135839.GL19099@suse.de> References: <1311265730-5324-1-git-send-email-mgorman@suse.de> <1311265730-5324-9-git-send-email-mgorman@suse.de> <20110803113706.GF27199@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20110803113706.GF27199@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 03, 2011 at 01:37:06PM +0200, Johannes Weiner wrote: > On Thu, Jul 21, 2011 at 05:28:50PM +0100, Mel Gorman wrote: > > Assuming that flusher threads will always write back dirty pages promptly > > then it is always faster for reclaimers to wait for flushers. This patch > > prevents kswapd writing back any filesystem pages. > > > > Signed-off-by: Mel Gorman > > Relying on the flushers may mean that every dirty page in the system > has to be written back before the pages from the zone of interest are > clean. > Yes. > De-facto we have only one mechanism to stay on top of the dirty pages > from a per-zone perspective, and that is single-page writeout from > reclaim. > Yes. > While we all agree that this sucks, we can not remove it unless we > have a replacement that makes zones reclaimable in a reasonable time > frame (or keep them reclaimable in the first place, what per-zone > dirty limits attempt to do). > > As such, please include > > Nacked-by: Johannes Weiner I've already dropped the patch. If I could, I would have signed this at the time as Signed-off-but-naking-it-anyway: Mel Gorman