From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
mingo@redhat.com, hpa@zytor.com, eranian@google.com,
linux-kernel@vger.kernel.org, robert.richter@amd.com,
tglx@linutronix.de, cjashfor@linux.vnet.ibm.com, mingo@elte.hu,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/urgent] perf sched: Fix list of events, dropping unsupported ':r' modifier
Date: Wed, 3 Aug 2011 14:06:27 -0300 [thread overview]
Message-ID: <20110803170627.GB29321@ghostprotocols.net> (raw)
In-Reply-To: <1312373931.1147.314.camel@twins>
Em Wed, Aug 03, 2011 at 02:18:51PM +0200, Peter Zijlstra escreveu:
> On Wed, 2011-08-03 at 14:11 +0200, Frederic Weisbecker wrote:
> > Look at tools/perf/util/parse-events.c:parse_single_tracepoint_event()
>
> fscking tinkerers.. that's horrid... strncmp("record") seriously wtf
> were you smoking, Acme why did you ever merge crap like that?
I haven't :-)
> Also, acme that can break stuff, remember the whole different
> ->sample_format discussion?
Yes, the evsel/evlist abstractions were in part motivated by the
multiple perf_event_attr->sample_type in the same session.
Being 5 weeks AFK was really nice but left me with a rather large
backlog :-)
> /me stomps off and goes do something useful, this userspace is like all
> other userspace.. a steaming pile of shit.
Nah, its all code, no matter what side of the fence.
- Arnaldo
next prev parent reply other threads:[~2011-08-03 17:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 9:29 [BUG] perf sched broken Stephane Eranian
2011-01-12 12:11 ` Arnaldo Carvalho de Melo
2011-01-12 19:10 ` Corey Ashford
2011-01-12 19:41 ` Corey Ashford
2011-01-12 19:52 ` Stephane Eranian
2011-01-12 20:22 ` Corey Ashford
2011-01-12 22:35 ` Corey Ashford
2011-01-12 22:38 ` Stephane Eranian
2011-01-13 1:53 ` Corey Ashford
2011-01-13 13:20 ` Arnaldo Carvalho de Melo
2011-01-14 7:25 ` [tip:perf/urgent] perf sched: Fix list of events, dropping unsupported ':r' modifier tip-bot for Stephane Eranian
2011-08-03 10:59 ` Peter Zijlstra
2011-08-03 11:37 ` Frederic Weisbecker
2011-08-03 11:42 ` Peter Zijlstra
2011-08-03 11:57 ` Frederic Weisbecker
2011-08-03 12:05 ` Peter Zijlstra
2011-08-03 12:11 ` Frederic Weisbecker
2011-08-03 12:18 ` Peter Zijlstra
2011-08-03 17:06 ` Arnaldo Carvalho de Melo [this message]
2011-08-03 19:49 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110803170627.GB29321@ghostprotocols.net \
--to=acme@redhat.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=robert.richter@amd.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox