From: Andrew Morton <akpm@linux-foundation.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Marc Zyngier <marc.zyngier@arm.com>,
Vasiliy Kulikov <segoon@openwall.com>,
Manuel Lauss <manuel.lauss@googlemail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Richard Weinberger <richard@nod.at>, Ingo Molnar <mingo@elte.hu>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>,
"Paul E. McKenney" <paul.mckenney@linaro.org>,
Kay Sievers <kay.sievers@vrfy.org>, Greg KH <greg@kroah.com>
Subject: Re: [PATCH] shm: fix a race between shm_exit() and shm_init()
Date: Wed, 3 Aug 2011 17:50:16 -0700 [thread overview]
Message-ID: <20110803175016.fb80b7f3.akpm@linux-foundation.org> (raw)
In-Reply-To: <CA+55aFzw-K6XvDzTwHRyqQWdkDO8Zqz8Ak1qgNTzf6a3L9=80A@mail.gmail.com>
On Wed, 3 Aug 2011 14:35:09 -1000 Linus Torvalds <torvalds@linux-foundation.org> wrote:
> --- a/init/main.c
> +++ b/init/main.c
> @@ -369,9 +369,12 @@ static noinline void __init_refok rest_init(void)
> init_idle_bootup_task(current);
> preempt_enable_no_resched();
> schedule();
> - preempt_disable();
> +
> + /* At this point, we can enable user mode helper functionality */
> + usermodehelper_enable();
>
> /* Call into cpu_idle with preempt disabled */
> + preempt_disable();
> cpu_idle();
> }
Well, it's still a workaround. We'll still have driver_init() trying
to run userspace helpers at an inappropriate time, and failing to do
so. Either something will break or it should not be attempting
attempting to do this at all.
Perhaps Kay and Greg can suggest how we can fix all this up?
next prev parent reply other threads:[~2011-08-04 0:48 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 18:01 initcall dependency problem (ns vs. threads) Vasiliy Kulikov
2011-08-01 18:20 ` Andrew Morton
2011-08-01 18:34 ` [kernel-hardening] " Vasiliy Kulikov
2011-08-01 19:03 ` Vasiliy Kulikov
2011-08-01 19:07 ` Andrew Morton
2011-08-01 19:22 ` Vasiliy Kulikov
2011-08-02 0:01 ` Linus Torvalds
2011-08-02 12:45 ` [PATCH] shm: fix a race between shm_exit() and shm_init() Vasiliy Kulikov
2011-08-02 12:51 ` Manuel Lauss
2011-08-02 13:23 ` Richard Weinberger
2011-08-02 13:29 ` Marc Zyngier
2011-08-02 20:33 ` Andrew Morton
2011-08-02 20:55 ` Andrew Morton
2011-08-03 5:30 ` Manuel Lauss
2011-08-03 8:05 ` Marc Zyngier
2011-08-03 8:19 ` Linus Torvalds
2011-08-03 10:04 ` Manuel Lauss
2011-08-03 10:30 ` Marc Zyngier
2011-08-03 13:13 ` Thadeu Lima de Souza Cascardo
2011-08-03 13:33 ` Kay Sievers
2011-08-03 13:45 ` Richard Weinberger
2011-08-04 0:35 ` Linus Torvalds
2011-08-04 0:50 ` Andrew Morton [this message]
2011-08-04 1:01 ` Linus Torvalds
2011-08-04 1:15 ` Kay Sievers
2011-08-04 8:26 ` Marc Zyngier
2011-08-03 7:43 ` Linus Torvalds
2011-08-03 7:50 ` Manuel Lauss
2011-08-03 8:00 ` Manuel Lauss
2011-08-03 19:33 ` Andrew Morton
2011-08-03 19:52 ` [kernel-hardening] " Vasiliy Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110803175016.fb80b7f3.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=kay.sievers@vrfy.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manuel.lauss@googlemail.com \
--cc=marc.zyngier@arm.com \
--cc=mingo@elte.hu \
--cc=paul.mckenney@linaro.org \
--cc=richard@nod.at \
--cc=segoon@openwall.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox