Re: [PATCH 16/25] dynamic_debug: require 'a' flag to explicitly mark pending queries

Jim Cromie
2011-07-27T17:28:28Z

On Tue, Jul 26, 2011 at 1:26 AM, Bart Van Assche <bvanassche@acm.org> wrote:
> On Mon, Jul 25, 2011 at 11:42 PM, Jim Cromie <jim.cromie@gmail.com> wrote:
>> +       if (!q1->module ^ !q2->module ||
>> +               !q1->filename ^ !q2->filename ||
>> +               !q1->function ^ !q2->function ||
>> +               !q1->format ^ !q2->format)
>> +               return false;  /* a match-spec set/unset state differs */
>
> I'd suggest to use "!=" here instead of "^" when testing booleans for
> inequality. At least for me that would make the above code easier to
> read.
>
> Bart.
>

yes. ^ is esoteric compared to !=
my github tree updated accordingly,
git://github.com/jimc/linux-2.6.git dyndbg-next