public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tino Keitel <tino.keitel@tikei.de>
To: Florian Mickler <florian@mickler.org>
Cc: mchehab@infradead.org, linux-kernel@vger.kernel.org, error27@gmail.com
Subject: Re: [PATCH] [media] vp7045: fix buffer setup
Date: Wed, 3 Aug 2011 21:02:04 +0200	[thread overview]
Message-ID: <20110803190204.GA18377@mac.home> (raw)
In-Reply-To: <1312288145-22292-1-git-send-email-florian@mickler.org>

On Tue, Aug 02, 2011 at 14:29:05 +0200, Florian Mickler wrote:
> dvb_usb_device_init calls the frontend_attach method of this driver which
> uses vp7045_usb_ob. In order to have a buffer ready in vp7045_usb_op, it has to
> be allocated before that happens.
> 
> Luckily we can use the whole private data as the buffer as it gets separately
> allocated on the heap via kzalloc in dvb_usb_device_init and is thus apt for
> use via usb_control_msg.
> 
> This fixes a
> 	BUG: unable to handle kernel paging request at 0000000000001e78
> 
> reported by Tino Keitel and diagnosed by Dan Carpenter.
> 
> Reported-by: Tino Keitel <tino.keitel@tikei.de>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Signed-off-by: Florian Mickler <florian@mickler.org>
> ---
> 
> Tino, can you test this?

Hi,

thanks for the patch. It works fine on top of 3.0. No more Oops at
boot, and the DVB-T receiver is working.

Regards,
Tino

  reply	other threads:[~2011-08-03 19:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-22 19:27 USB related "unable to handle kernel paging request" in 3.0.0-rc7 Tino Keitel
2011-07-25 19:47 ` Maciej Rutecki
2011-08-02  8:54 ` Dan Carpenter
2011-08-02  9:51   ` Florian Mickler
2011-08-02 10:40     ` Florian Mickler
2011-08-02 11:10       ` Florian Mickler
2011-08-02 11:51         ` Florian Mickler
2011-08-02 11:56           ` Dan Carpenter
2011-08-02 11:35       ` Dan Carpenter
2011-08-02 11:40         ` Dan Carpenter
2011-08-02 12:02         ` Florian Mickler
2011-08-02 12:29 ` [PATCH] [media] vp7045: fix buffer setup Florian Mickler
2011-08-03 19:02   ` Tino Keitel [this message]
2011-08-09 20:08     ` Tino Keitel
2011-08-10  9:46       ` Florian Mickler
2011-08-10 10:05       ` Florian Mickler
2011-08-19 16:35         ` Florian Mickler
2011-08-24 16:26           ` Tino Keitel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110803190204.GA18377@mac.home \
    --to=tino.keitel@tikei.de \
    --cc=error27@gmail.com \
    --cc=florian@mickler.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox