Re: [Xen-devel] [PATCH 1/3] xen/pv-on-hvm kexec: add xs_introduce to shutdown watches from old kernel

Olaf Hering
2011-08-09T09:28:32Z

On Tue, Aug 09, Ian Campbell wrote:

> > +++ linux-3.0/drivers/xen/xenbus/xenbus_xs.c

> > + return xs_error(xs_talkv(XBT_NIL, XS_INTRODUCE, iov,
> > + ARRAY_SIZE(iov), NULL));
>
> What should we do if this fails?

There is not much other than printk and move on.
A kexec boot cant be detected from withing kexec.

> > + snprintf(domid, sizeof(domid), "%u", DOMID_SELF);
> > + snprintf(mfn, sizeof(mfn), "%lu", xen_store_mfn);
> > + snprintf(port, sizeof(port), "%d", xen_store_evtchn);
>
> These can be within the if, or better within the xs_introduce function
> itself.

Yes, thats true. I will rearrange the code.

Olaf