From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Len Brown <lenb@kernel.org>
Cc: Andrew Lutomirski <luto@mit.edu>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Fenghua Yu <fenghua.yu@intel.com>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH 2/2] x86: Enable monitor/mwait on Intel if BIOS hasn't already
Date: Thu, 4 Aug 2011 20:41:17 +0100 [thread overview]
Message-ID: <20110804194117.GA5265@srcf.ucam.org> (raw)
In-Reply-To: <alpine.LFD.2.02.1108031514550.22067@x980>
On Wed, Aug 03, 2011 at 03:17:59PM -0400, Len Brown wrote:
> > >> What machine has this BIOS bug, and are you running
> > >> the latest version of the BIOS?
> > >
> > > Intel DQ67SW, version SWQ6710H.86A.0051.2011.0413.1154. This is not
> > > quite up-to-date -- I'll test a newer BIOS.
> >
> > SWQ6710H.86A.0053.2011.0615.1535 has the same problem. It fixed ASPM, though :)
> >
> > Should I redo the patch with a printk to warn about the firmware bug?
>
> I would hope that a patch that _only_ prints [Firmware bug]
> should be enough. This isn't the kind of workaround
> that we should really have to carry in the kernel.
We can't trust BIOS authors to get things right. Where we can reliably
fix up things that are broken, we should do so.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-08-04 19:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-03 15:47 [PATCH 0/2] Forcibly enable some MISC_ENABLE features on Intel Andy Lutomirski
2011-08-03 15:47 ` [PATCH 1/2] x86: Enable fast strings on Intel if BIOS hasn't already Andy Lutomirski
2011-08-03 16:34 ` Yu, Fenghua
2011-08-03 16:39 ` Andrew Lutomirski
2011-08-03 15:47 ` [PATCH 2/2] x86: Enable monitor/mwait " Andy Lutomirski
2011-08-03 16:15 ` Len Brown
2011-08-03 16:22 ` Andrew Lutomirski
2011-08-03 16:42 ` Andrew Lutomirski
2011-08-03 19:17 ` Len Brown
2011-08-04 3:18 ` Andrew Lutomirski
2011-08-04 19:41 ` Matthew Garrett [this message]
2011-08-04 21:54 ` Len Brown
2011-08-04 21:56 ` Matthew Garrett
2011-08-05 9:43 ` Ingo Molnar
2011-08-06 11:42 ` Andrew Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110804194117.GA5265@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=fenghua.yu@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@mit.edu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox