From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753479Ab1HDTld (ORCPT ); Thu, 4 Aug 2011 15:41:33 -0400 Received: from cavan.codon.org.uk ([93.93.128.6]:47337 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751267Ab1HDTlZ (ORCPT ); Thu, 4 Aug 2011 15:41:25 -0400 Date: Thu, 4 Aug 2011 20:41:17 +0100 From: Matthew Garrett To: Len Brown Cc: Andrew Lutomirski , x86@kernel.org, linux-kernel@vger.kernel.org, Fenghua Yu , linux-acpi@vger.kernel.org Subject: Re: [PATCH 2/2] x86: Enable monitor/mwait on Intel if BIOS hasn't already Message-ID: <20110804194117.GA5265@srcf.ucam.org> References: <5bec80947da3fb72f2f18fbe6d924a69f83fbed9.1312386029.git.luto@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: mjg59@cavan.codon.org.uk X-SA-Exim-Scanned: No (on cavan.codon.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 03, 2011 at 03:17:59PM -0400, Len Brown wrote: > > >> What machine has this BIOS bug, and are you running > > >> the latest version of the BIOS? > > > > > > Intel DQ67SW, version SWQ6710H.86A.0051.2011.0413.1154.  This is not > > > quite up-to-date -- I'll test a newer BIOS. > > > > SWQ6710H.86A.0053.2011.0615.1535 has the same problem. It fixed ASPM, though :) > > > > Should I redo the patch with a printk to warn about the firmware bug? > > I would hope that a patch that _only_ prints [Firmware bug] > should be enough. This isn't the kind of workaround > that we should really have to carry in the kernel. We can't trust BIOS authors to get things right. Where we can reliably fix up things that are broken, we should do so. -- Matthew Garrett | mjg59@srcf.ucam.org