[PATCH -v3 0/3] xen-blkback: refactor vbd remove/disconnect.

Joe Jin
2011-08-04T07:21:52Z

This patchset is a backport and original patch author is Daniel Stodden:
http://xenbits.xen.org/hg/XCP/linux-2.6.32.pq.hg/file/tip/CA-7672-blkback-shutdown.patch

Initial issue:
When we do block device attach/detach test with below steps, umount hang
in guest and the guest unable to shutdown:

1. start guest with the latest kernel.
2. attach new block device by xm block-attach in Dom0
3. mount new disk in guest
4. execute xm block-detach to detach the block device in dom0 until timeout
5. try to unmount the disk in guest, umount hung. at here, any IOs to the
device will hang.

Root cause:
This caused by 'xm block-detach' in Dom0 set backend device's state to
'XenbusStateClosing', frontend received the notification and
blkfront_closing() be called, at the moment, the disk still using by guest,
so frontend refused to close. In the blkfront_closing(), frontend send a
notification to backend said that the its state switched to 'Closing', when
backend got the event, it will disconnect from real device, at here any IO
request will be stuck, even tried to release the disk by umount.

So this may fix either frontend or backend, I have send a fix for frontend:
https://lkml.org/lkml/2011/7/8/159
Ian think we should fix it from backend and he pointed out Daniel Stodden have
submitted a patch(see above link) for xen-blkback, I tried it and it works
well.

Changes:
v3:
- Unregister the device when backend state switch to XenbusStateClosed.

v2:
- Reformat code style.
- Per Knoard suggestions, change some int defines to bool.

drivers/block/xen-blkback/blkback.c | 10 +--
drivers/block/xen-blkback/common.h | 5 +
drivers/block/xen-blkback/xenbus.c | 206 +++++++++++++++++++++++++++++++++++++++++++++++++++++++-------
3 files changed, 195 insertions(+), 26 deletions(-)