Re: [PATCH -next] watchdog: fix it8712f_wdt build errors

Wim Van Sebroeck
2011-07-25T19:02:46Z

Hi Randy,

> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Fix build errors by adding missing header file:
>
> drivers/watchdog/it8712f_wdt.c:127: error: implicit declaration of function 'request_muxed_region'
> drivers/watchdog/it8712f_wdt.c:141: error: implicit declaration of function 'release_region'
> drivers/watchdog/it8712f_wdt.c:412: error: implicit declaration of function 'request_region'
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
> drivers/watchdog/it8712f_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20110725.orig/drivers/watchdog/it8712f_wdt.c
> +++ linux-next-20110725/drivers/watchdog/it8712f_wdt.c
> @@ -31,6 +31,7 @@
> #include <linux/spinlock.h>
> #include <linux/uaccess.h>
> #include <linux/io.h>
> +#include <linux/ioport.h>
>
> #define NAME "it8712f_wdt"

I see what happened: The pci.h removal patch compiled ok and the patch that introduced the muxed_region code also compiled ok (with pci.h still included). However both patches together reveal the issue indeed (pci.h includes ioport.h).

Sorry about that. I have added your patch for it.

Thanks,
wim.