public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] devtmpfs: Fix section mismatch on devtmpfsd()
Date: Thu, 4 Aug 2011 15:54:18 -0700	[thread overview]
Message-ID: <20110804225418.GA2505@suse.de> (raw)
In-Reply-To: <1312497371-25685-1-git-send-email-grant.likely@secretlab.ca>

On Thu, Aug 04, 2011 at 11:36:11PM +0100, Grant Likely wrote:
> devtmpfsd_init() references setup_done which is __initdata, but
> devtmpfsd() is not an __init function.  The code is fine, because it
> is never referenced after discarding __init sections, but it leaves
> some additional code that can be discarded with the rest of __init and
> it causes gcc to complain with a section mismatch warning.

I have a simpler patch here that just removes the __initdata function,
which is simpler.

I hate the initdata stuff, it's almost always pointless...

Would that solve the problem for you as well?

thanks,

greg k-h

  reply	other threads:[~2011-08-04 22:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-04 22:36 [PATCH] devtmpfs: Fix section mismatch on devtmpfsd() Grant Likely
2011-08-04 22:54 ` Greg KH [this message]
2011-08-04 23:32   ` Grant Likely
2011-08-04 23:42     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110804225418.GA2505@suse.de \
    --to=gregkh@suse.de \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox