Re: [PATCH] devtmpfs: Fix section mismatch on devtmpfsd()

[Greg KH <gregkh@suse.de>]

On Fri, Aug 05, 2011 at 12:32:15AM +0100, Grant Likely wrote:
> On Thu, Aug 4, 2011 at 11:54 PM, Greg KH <gregkh@suse.de> wrote:
> > On Thu, Aug 04, 2011 at 11:36:11PM +0100, Grant Likely wrote:
> >> devtmpfsd_init() references setup_done which is __initdata, but
> >> devtmpfsd() is not an __init function.  The code is fine, because it
> >> is never referenced after discarding __init sections, but it leaves
> >> some additional code that can be discarded with the rest of __init and
> >> it causes gcc to complain with a section mismatch warning.
> >
> > I have a simpler patch here that just removes the __initdata function,
> > which is simpler.
> >
> > I hate the initdata stuff, it's almost always pointless...
> 
> initdata I don't mind.  Discarding stuff that is no longer necessary
> isn't a bad thing and I don't find it that onerous.  __devinit* seems
> less useful since I've never worked on a system that can actually
> discard it.

Yes, that's the one I really want to get rid of.  One of these days on a
long flight I'll work up a series of patches to drop it...

thanks,

greg k-h