* [PATCH] acerhdf.c: spaces in aliased changed to *
@ 2011-07-28 14:05 Anton V. Boyarshinov
2011-07-29 21:55 ` Peter Feuerer
2011-08-05 19:22 ` Matthew Garrett
0 siblings, 2 replies; 3+ messages in thread
From: Anton V. Boyarshinov @ 2011-07-28 14:05 UTC (permalink / raw)
To: Peter Feuerer; +Cc: Matthew Garrett, platform-driver-x86, linux-kernel
It seems that aliases shouldn't contain spaces, as
module-init-tools uses them as delimeters in module.alias file
Signed-off-by: Anton V. Boyarshinov <boyarsh@altlinux.org>
---
drivers/platform/x86/acerhdf.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
index fca3489..7a8568b 100644
--- a/drivers/platform/x86/acerhdf.c
+++ b/drivers/platform/x86/acerhdf.c
@@ -703,15 +703,15 @@ MODULE_LICENSE("GPL");
MODULE_AUTHOR("Peter Feuerer");
MODULE_DESCRIPTION("Aspire One temperature and fan driver");
MODULE_ALIAS("dmi:*:*Acer*:pnAOA*:");
-MODULE_ALIAS("dmi:*:*Acer*:pnAspire 1410*:");
-MODULE_ALIAS("dmi:*:*Acer*:pnAspire 1810*:");
+MODULE_ALIAS("dmi:*:*Acer*:pnAspire*1410*:");
+MODULE_ALIAS("dmi:*:*Acer*:pnAspire*1810*:");
MODULE_ALIAS("dmi:*:*Acer*:pnAO531*:");
MODULE_ALIAS("dmi:*:*Gateway*:pnAOA*:");
MODULE_ALIAS("dmi:*:*Gateway*:pnLT31*:");
-MODULE_ALIAS("dmi:*:*Packard Bell*:pnAOA*:");
-MODULE_ALIAS("dmi:*:*Packard Bell*:pnDOA*:");
-MODULE_ALIAS("dmi:*:*Packard Bell*:pnDOTMU*:");
-MODULE_ALIAS("dmi:*:*Packard Bell*:pnDOTMA*:");
+MODULE_ALIAS("dmi:*:*Packard*Bell*:pnAOA*:");
+MODULE_ALIAS("dmi:*:*Packard*Bell*:pnDOA*:");
+MODULE_ALIAS("dmi:*:*Packard*Bell*:pnDOTMU*:");
+MODULE_ALIAS("dmi:*:*Packard*Bell*:pnDOTMA*:");
module_init(acerhdf_init);
module_exit(acerhdf_exit);
--
1.7.2.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] acerhdf.c: spaces in aliased changed to *
2011-07-28 14:05 [PATCH] acerhdf.c: spaces in aliased changed to * Anton V. Boyarshinov
@ 2011-07-29 21:55 ` Peter Feuerer
2011-08-05 19:22 ` Matthew Garrett
1 sibling, 0 replies; 3+ messages in thread
From: Peter Feuerer @ 2011-07-29 21:55 UTC (permalink / raw)
To: Anton V. Boyarshinov; +Cc: Matthew Garrett, platform-driver-x86, linux-kernel
Hi,
Matthew, please apply, thanks.
Anton V. Boyarshinov writes:
> It seems that aliases shouldn't contain spaces, as
> module-init-tools uses them as delimeters in module.alias file
>
> Signed-off-by: Anton V. Boyarshinov <boyarsh@altlinux.org>
Acked-by: Peter Feuerer <peter@piie.net>
> ---
> drivers/platform/x86/acerhdf.c | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
> index fca3489..7a8568b 100644
> --- a/drivers/platform/x86/acerhdf.c
> +++ b/drivers/platform/x86/acerhdf.c
> @@ -703,15 +703,15 @@ MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Peter Feuerer");
> MODULE_DESCRIPTION("Aspire One temperature and fan driver");
> MODULE_ALIAS("dmi:*:*Acer*:pnAOA*:");
> -MODULE_ALIAS("dmi:*:*Acer*:pnAspire 1410*:");
> -MODULE_ALIAS("dmi:*:*Acer*:pnAspire 1810*:");
> +MODULE_ALIAS("dmi:*:*Acer*:pnAspire*1410*:");
> +MODULE_ALIAS("dmi:*:*Acer*:pnAspire*1810*:");
> MODULE_ALIAS("dmi:*:*Acer*:pnAO531*:");
> MODULE_ALIAS("dmi:*:*Gateway*:pnAOA*:");
> MODULE_ALIAS("dmi:*:*Gateway*:pnLT31*:");
> -MODULE_ALIAS("dmi:*:*Packard Bell*:pnAOA*:");
> -MODULE_ALIAS("dmi:*:*Packard Bell*:pnDOA*:");
> -MODULE_ALIAS("dmi:*:*Packard Bell*:pnDOTMU*:");
> -MODULE_ALIAS("dmi:*:*Packard Bell*:pnDOTMA*:");
> +MODULE_ALIAS("dmi:*:*Packard*Bell*:pnAOA*:");
> +MODULE_ALIAS("dmi:*:*Packard*Bell*:pnDOA*:");
> +MODULE_ALIAS("dmi:*:*Packard*Bell*:pnDOTMU*:");
> +MODULE_ALIAS("dmi:*:*Packard*Bell*:pnDOTMA*:");
>
> module_init(acerhdf_init);
> module_exit(acerhdf_exit);
> --
> 1.7.2.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] acerhdf.c: spaces in aliased changed to *
2011-07-28 14:05 [PATCH] acerhdf.c: spaces in aliased changed to * Anton V. Boyarshinov
2011-07-29 21:55 ` Peter Feuerer
@ 2011-08-05 19:22 ` Matthew Garrett
1 sibling, 0 replies; 3+ messages in thread
From: Matthew Garrett @ 2011-08-05 19:22 UTC (permalink / raw)
To: Anton V. Boyarshinov; +Cc: Peter Feuerer, platform-driver-x86, linux-kernel
Applied, thanks.
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-05 19:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-28 14:05 [PATCH] acerhdf.c: spaces in aliased changed to * Anton V. Boyarshinov
2011-07-29 21:55 ` Peter Feuerer
2011-08-05 19:22 ` Matthew Garrett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox