From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] mfd: Convert pcf50633 to use new register map API
Date: Mon, 8 Aug 2011 14:07:14 +0900 [thread overview]
Message-ID: <20110808050712.GA31168@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4E3F5817.2090405@metafoo.de>
On Mon, Aug 08, 2011 at 05:29:27AM +0200, Lars-Peter Clausen wrote:
> > EXPORT_SYMBOL_GPL(pcf50633_reg_clear_bits);
> I would prefer making the wrappers static inline functions.
I considered doing this for all the conversions but preferred to go for
a minimal diff for ease of review, it seems better to do such code
motion changes later on. Similarly for the return value stuff which
I'll update shortly.
> --- a/drivers/base/regmap/regmap-i2c.c
> +++ b/drivers/base/regmap/regmap-i2c.c
> @@ -70,6 +70,8 @@ static int regmap_i2c_read(struct device *dev,
> struct i2c_msg xfer[2];
> int ret;
>
> + printk("regmap_read: %d %d\n", reg_size, val_size);
> +
Clearly not ideal...
next prev parent reply other threads:[~2011-08-08 5:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-06 3:45 [PATCH] mfd: Convert pcf50633 to use new register map API Mark Brown
2011-08-08 3:29 ` Lars-Peter Clausen
2011-08-08 5:07 ` Mark Brown [this message]
2011-08-22 9:03 ` Samuel Ortiz
2011-08-22 9:10 ` Samuel Ortiz
-- strict thread matches above, loose matches on Subject: below --
2011-08-08 5:14 Mark Brown
2011-08-08 6:37 ` Lars-Peter Clausen
2011-08-08 8:04 Mark Brown
2011-08-10 4:21 ` Lars-Peter Clausen
2011-08-22 9:16 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110808050712.GA31168@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox