Re: fix rcu annotations noise in cred.h

Paul E. McKenney
2011-08-08T12:34:47Z

On Mon, Aug 08, 2011 at 09:18:29AM +0100, David Howells wrote:
>
> Al Viro <viro@ZenIV.linux.org.uk> wrote:
>
> > #define current_cred() \
> > - (current->cred)
> > + (*(__force struct cred **)&current->cred)
>
> No. You've cast away the const. Please don't do that.
>
> Paul: isn't there some better way of doing this using an RCU wrapper macro?
>
> #define current_cred() \
> rcu_dereference_protected(current->cred, 1)
>
> Perhaps?

This is indeed what rcu_dereference_protected() is intended for.

Thanx, Paul