Re: [PATCH] x86: Add reboot quirk for Dell Precision M4600

Len Brown
2011-08-06T15:32:34Z

On Sat, 6 Aug 2011, H. Peter Anvin wrote:

> Ingo Molnar <mingo@elte.hu> wrote:
>
> >* Mel Gorman <mgorman@suse.de> wrote:
> >
> >> ACPI reboot does not work for Dell Precision M4600. Detect this
> >> machine via DMI and force the use of the PCI reboot method.
> >>
> >> Reported-and-tested-by: Bruno Friedmann <bruno@ioda-net.ch>
> >> Signed-off-by: Mel Gorman <mgorman@suse.de>
> >> ---
> >> arch/x86/kernel/reboot.c | 9 +++++++++
> >> 1 files changed, 9 insertions(+), 0 deletions(-)
> >
> >Weird - ACPI is the default Windows method of reboot - how come it
> >does not work on that box? Does Windows work around this specific
> >machine (unlikely), or is our ACPI boot sequence not 100% compatible
> >with the Windows method (more likely IMO)?
>
> It seems almost all the affected machines are Dell, too... very odd, no?

Dell website says that the M4600 is current,
and ships with Windows 7. It is a "mobile workstation",
so it is more likely to have a windows "feature" driver,
say, than Dell's servers.

Matthew,
Did you do your reboot comopatibility test using Win7,
or something older?

BTW, it would be nice if ACPI incompatibilities and workarounds
somehow got stuck in the ACPI code rather than the arch code.
Unfortunately this kind sets a working reboot method instead
of disabling a non-working one -- so what it overrides has
changed when the default changed.

thanks,
-Len Brown, Intel Open Source Technolgy Center