From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
Pavel Machek <pavel@ucw.cz>, Jiri Slaby <jslaby@suse.cz>
Subject: Re: [patch 1/1] [PATCH] include storage keys in hibernation image.
Date: Tue, 9 Aug 2011 17:45:24 +0200 [thread overview]
Message-ID: <20110809174524.45cd496d@mschwide> (raw)
In-Reply-To: <201107290001.14465.rjw@sisk.pl>
On Fri, 29 Jul 2011 00:01:14 +0200
"Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> Sorry for the extreme delay.
No big deal, I have been busy with other things anyway.
> Having reconsidered things I think the code under the #ifdef above
> should really go to arch/s390.
Ok, that is reasonable.
> Now, for the purpose of exporting the headers I'd introduce
> CONFIG_ARCH_SAVE_PAGE_KEYS and make S390 do
>
> select ARCH_SAVE_PAGE_KEYS if HIBERNATION
>
> and I'd put a #ifdef depending on that into include/linux/suspend.h.
>
> Apart from this, I have only one complaint, which is that the kerneldoc
> comments should follow the standard (the other comments in snapshot.c don't,
> but that's a matter for a separate patch).
Sounds good. I will come up with new patches for this and resend them
for review. Might be one or two weeks though, currently conferencing in
Orlando..
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2011-08-09 15:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 7:45 [patch 0/1] [RFC] include storage keys in hibernation image Martin Schwidefsky
2011-06-08 7:45 ` [patch 1/1] [PATCH] " Martin Schwidefsky
2011-06-12 12:41 ` Rafael J. Wysocki
2011-06-14 8:50 ` Martin Schwidefsky
2011-06-14 20:50 ` Rafael J. Wysocki
2011-06-15 7:36 ` Martin Schwidefsky
2011-06-15 23:21 ` Rafael J. Wysocki
2011-07-03 17:46 ` Pavel Machek
2011-07-04 8:09 ` Martin Schwidefsky
2011-07-07 21:36 ` Rafael J. Wysocki
2011-07-08 8:29 ` Martin Schwidefsky
2011-07-28 22:01 ` Rafael J. Wysocki
2011-08-09 15:45 ` Martin Schwidefsky [this message]
2011-08-09 19:56 ` Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2011-08-16 14:14 [patch 0/1] [patch 0/1] " Martin Schwidefsky
2011-08-16 14:14 ` [patch 1/1] [PATCH] " Martin Schwidefsky
2011-08-16 17:56 ` Rafael J. Wysocki
2011-08-17 7:43 ` Martin Schwidefsky
2011-08-17 9:15 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110809174524.45cd496d@mschwide \
--to=schwidefsky@de.ibm.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linux-s390@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox