From: Don Zickus <dzickus@redhat.com>
To: Alex Neronskiy <zakmagnus@chromium.org>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
Ingo Molnar <mingo@elte.hu>,
Mandeep Singh Baines <msb@chromium.org>,
Alex Neronskiy <zakmagnus@chromium.com>
Subject: Re: [PATCH v5 2/2] Output stall data in debugfs
Date: Wed, 10 Aug 2011 09:06:52 -0400 [thread overview]
Message-ID: <20110810130652.GI1972@redhat.com> (raw)
In-Reply-To: <1312935763-23570-2-git-send-email-zakmagnus@chromium.org>
On Tue, Aug 09, 2011 at 05:22:43PM -0700, Alex Neronskiy wrote:
> From: Alex Neronskiy <zakmagnus@chromium.com>
>
> Instead of using the log, use debugfs for output of both stall
> lengths and stack traces. Printing to the log can result in
> watchdog touches, distorting the very events being measured.
> Additionally, the information will not distract from lockups
> when users view the log.
>
> A two-buffer system is used to ensure that the trace information
> can always be recorded without contention.
This looks like it can work. I'll try to play with it today. Can I ask
that you add some comments to document the way the buffers work, so others
know what is going on to.
Cheers,
Don
prev parent reply other threads:[~2011-08-10 13:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 0:22 [PATCH v5 1/2] Track hard and soft "short lockups" or "stalls." Alex Neronskiy
2011-08-10 0:22 ` [PATCH v5 2/2] Output stall data in debugfs Alex Neronskiy
2011-08-10 13:06 ` Don Zickus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110810130652.GI1972@redhat.com \
--to=dzickus@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=msb@chromium.org \
--cc=peterz@infradead.org \
--cc=zakmagnus@chromium.com \
--cc=zakmagnus@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox