From: Arnd Bergmann <arnd@arndb.de>
To: "Mark Rutland" <mark.rutland@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux@arm.linux.org.uk,
tglx@linutronix.de, weizeng.he@csr.com, workgroup.linux@csr.com,
"'Barry Song'" <21cnbao@gmail.com>,
"'Grant Likely'" <grant.likely@secretlab.ca>,
"'Olof Johansson'" <olof@lixom.net>,
"'Rob Herring'" <rob.herring@calxeda.com>,
"Will Deacon" <Will.Deacon@arm.com>
Subject: Re: Subject: L2x0 OF properties do not include interrupt #
Date: Wed, 10 Aug 2011 16:09:56 +0200 [thread overview]
Message-ID: <201108101609.56995.arnd@arndb.de> (raw)
In-Reply-To: <000201cc575b$c1229010$4367b030$@rutland@arm.com>
On Wednesday 10 August 2011, Mark Rutland wrote:
> I realise I'm a bit late to the party here, but I'd like to propose adding an
> optional interrupt parameter to the binding. I'm not aware of any
> implementations which use separate interrupts, but given the binding
> seems to be generic across L2CC implementations (and is not limited simply to
> the L2x0), having a list rather than a single interrupt may be appropriate for
> someone.
Sounds good, thanks for pointing this out.
How many possible interrupt sources are there? If there is only a small number
of those (e.g. at most 4), we might just list all of them and register
them from the driver even if they are all the same.
> This would boil down to (for the moment) a Documentation change along the lines of:
>
> > diff --git a/Documentation/devicetree/bindings/arm/l2cc.txt b/Documentation/devicetree/bindings/arm/l2cc.txt
> > index f50e021..d4b387b 100644
> > --- a/Documentation/devicetree/bindings/arm/l2cc.txt
> > +++ b/Documentation/devicetree/bindings/arm/l2cc.txt
> > @@ -28,6 +28,7 @@ Optional properties:
> > - arm,filter-ranges : <start length> Starting address and length of window to
> > filter. Addresses in the filter window are directed to the M1 port. Other
> > addresses will go to the M0 port.
> > +- interrupt : A combined interrupt.
> >
> > Example:
> >
> > @@ -39,4 +40,5 @@ L2: cache-controller {
> > arm,filter-latency = <0x80000000 0x8000000>;
> > cache-unified;
> > cache-level = <2>;
> > + interrupt = <45>;
> > };
>
> Any thoughts?
Do we also need to document an interrupt-parent property, or is that implied?
Arnd
next prev parent reply other threads:[~2011-08-10 14:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <000201cc575b$c1229010$4367b030$@rutland@arm.com>
2011-08-10 13:59 ` Subject: L2x0 OF properties do not include interrupt # Rob Herring
2011-08-10 14:10 ` Will Deacon
2011-08-10 14:24 ` Arnd Bergmann
2011-08-10 14:28 ` Will Deacon
2011-08-11 13:05 ` Arnd Bergmann
2011-08-11 13:09 ` Will Deacon
2011-08-11 15:32 ` Rob Herring
2011-08-11 15:38 ` Will Deacon
2011-08-11 16:06 ` Rob Herring
2011-08-11 16:34 ` Will Deacon
2011-08-12 9:02 ` Russell King - ARM Linux
2011-08-10 14:37 ` Rob Herring
2011-08-10 14:39 ` Will Deacon
2011-08-10 14:09 ` Arnd Bergmann [this message]
2011-08-10 14:31 ` Rob Herring
2011-08-10 15:12 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108101609.56995.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=21cnbao@gmail.com \
--cc=Will.Deacon@arm.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=rob.herring@calxeda.com \
--cc=tglx@linutronix.de \
--cc=weizeng.he@csr.com \
--cc=workgroup.linux@csr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox