From: Greg KH <gregkh@suse.de>
To: "Mansoor, Illyas" <illyas.mansoor@intel.com>
Cc: "Liu, ShuoX" <shuox.liu@intel.com>,
"linux-pm@lists.linux-foundation.org"
<linux-pm@lists.linux-foundation.org>,
"Brown, Len" <len.brown@intel.com>,
"Yanmin_zhang@linux.intel.com" <Yanmin_zhang@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [linux-pm] [PATCH v4] PM: add statistics debugfs file for suspend to ram
Date: Wed, 10 Aug 2011 12:45:29 -0700 [thread overview]
Message-ID: <20110810194529.GA5590@suse.de> (raw)
In-Reply-To: <EB6073F1DF78F9439DFDCC701BC6466007B36A0CCE@bgsmsx502.gar.corp.intel.com>
On Wed, Aug 10, 2011 at 11:30:40PM +0530, Mansoor, Illyas wrote:
> > +struct suspend_stats suspend_stats;
> > static DEFINE_MUTEX(dpm_list_mtx);
> > static pm_message_t pm_transition;
> >
> > @@ -464,8 +465,12 @@ void dpm_resume_noirq(pm_message_t state)
> > mutex_unlock(&dpm_list_mtx);
> >
> > error = device_resume_noirq(dev, state);
> > - if (error)
> > + if (error) {
> > + suspend_stats.failed_resume_noirq++;
> > + dpm_save_failed_step(SUSPEND_RESUME_NOIRQ);
> > + dpm_save_failed_dev(dev_name(dev));
>
> Please make these statistics conditionally enabled, so on a production system
> If we need to disable these statistics code we should be able to do so.
Why, are they taking time or space that is needed for something else?
What's the downside here of just not always having this enabled?
greg k-h
next prev parent reply other threads:[~2011-08-10 19:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 7:28 [PATCH v4] PM: add statistics debugfs file for suspend to ram Liu, ShuoX
2011-08-10 18:00 ` [linux-pm] " Mansoor, Illyas
2011-08-10 19:45 ` Greg KH [this message]
2011-08-10 19:52 ` Mansoor, Illyas
2011-08-10 19:58 ` Greg KH
2011-08-10 20:20 ` Mansoor, Illyas
2011-08-10 20:25 ` Mansoor, Illyas
2011-08-12 7:04 ` Pavel Machek
2011-08-12 7:13 ` Rafael J. Wysocki
2011-08-10 21:07 ` Rafael J. Wysocki
2011-08-10 21:44 ` Pavel Machek
2011-08-11 1:55 ` Yanmin Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110810194529.GA5590@suse.de \
--to=gregkh@suse.de \
--cc=Yanmin_zhang@linux.intel.com \
--cc=illyas.mansoor@intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=shuox.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox