From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755248Ab1HJWiV (ORCPT ); Wed, 10 Aug 2011 18:38:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38821 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751651Ab1HJWiU (ORCPT ); Wed, 10 Aug 2011 18:38:20 -0400 Date: Wed, 10 Aug 2011 18:38:16 -0400 From: Dave Jones To: Linux Kernel Mailing List Cc: Randy Dunlap , Borislav Petkov Subject: Re: EDAC: Correct Kconfig dependencies Message-ID: <20110810223816.GA28802@redhat.com> Mail-Followup-To: Dave Jones , Linux Kernel Mailing List , Randy Dunlap , Borislav Petkov References: <201108101859.p7AIx1tU027687@hera.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201108101859.p7AIx1tU027687@hera.kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 10, 2011 at 06:59:01PM +0000, Linux Kernel wrote: > Gitweb: http://git.kernel.org/linus/af9d220bac41dc3201893e1601cc7c44f7da4498 > Commit: af9d220bac41dc3201893e1601cc7c44f7da4498 > Parent: f2c0d0266cc5eb36a4aa44944b4096ec121490aa > Author: Borislav Petkov > AuthorDate: Wed Aug 10 14:43:30 2011 +0200 > Committer: Linus Torvalds > CommitDate: Wed Aug 10 10:57:42 2011 -0700 > > EDAC: Correct Kconfig dependencies > > Both AMD and Intel i7 EDAC drivers use MCE features and are thus > dependent of this functionality present in the kernel. Express this in > Kconfig so that randconfig builds don't break. > > Reported-by: Randy Dunlap > Signed-off-by: Borislav Petkov > Acked-by: Randy Dunlap > Signed-off-by: Linus Torvalds This commit broke the build for me.. drivers/edac/i7core_edac.c:259:18: error: field ‘edac_mce’ has incomplete type drivers/edac/i7core_edac.c:262:23: error: ‘MCE_LOG_LEN’ undeclared here (not in a function) drivers/edac/i7core_edac.c: In function ‘i7core_mce_output_error’: drivers/edac/i7core_edac.c:1671:25: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1672:20: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1673:23: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1674:15: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1675:18: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1676:18: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1680:7: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1742:22: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1742:31: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1743:39: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1744:15: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1751:7: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c: In function ‘i7core_check_error’: drivers/edac/i7core_edac.c:1787:50: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1791:3: error: invalid use of undefined type ‘struct mce’ drivers/edac/i7core_edac.c:1793:49: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c: In function ‘i7core_mce_check_error’: drivers/edac/i7core_edac.c:1838:11: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1842:9: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1847:293: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1859:52: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1864:9: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c: In function ‘i7core_unregister_mci’: drivers/edac/i7core_edac.c:1910:2: error: implicit declaration of function ‘edac_mce_unregister’ [-Werror=implicit-function-declaration] drivers/edac/i7core_edac.c: In function ‘i7core_register_mci’: drivers/edac/i7core_edac.c:2008:2: error: implicit declaration of function ‘edac_mce_register’ [-Werror=implicit-function-declaration] it needs at least to include asm/mce.h for all the missing types, but the bigger problem is that CONFIG_EDAC_MCE not being select'd means that we never build edac_mce.o (it's an unselectable bool in drivers/edac/Kconfig) Dave