Re: Missing put_cpu() in arch/ia64/sn/kernel/sn2/sn_hwperf.c?

[Jack Steiner <steiner@sgi.com>]

On Thu, Aug 11, 2011 at 05:58:29AM -0500, Robin Holt wrote:
> On Thu, Aug 11, 2011 at 08:12:45AM +0200, Jes Sorensen wrote:
> > On 08/08/11 23:37, Tony Luck wrote:
> > > On Mon, Aug 8, 2011 at 11:05 AM, Thomas Meyer <thomas@m3y3r.de> wrote:
> > >> The function sn_hwperf_op_cpu() seems to miss a corresponding put_cpu().
> > >>
> > >> Or is this done in another function? I didn't find it.
> > > 
> > > It would be hard to do it elsewhere - this function may not have done
> > > a get_cpu() [in the cpu == SN_HWPERF_ARG_ANY_CPU case].
> > > 
> > > The logic is a bit tortuous here ... perhaps simpler to split the tests
> > > up.  Does the attached patch look right?
> > 
> > Hi Tony,
> > 
> > You probably want someone from SGI to look at it, so I'll forward to
> > Robin Holt.
> > 
> > I haven't been at SGI for about 2 years now :)
> 
> And I will bounce the question on to Jack.  I believe he will probably
> pass it on to somebody more familiar with sn_hwperf.  Tony's patch looks
> much clearer to me.  I would have answered that I thought this was the
> right patch until I saw the '... else { put_cpu(); ...' which made me
> think we need a closer look.

Agree - looks like a missing put_cpu(). Tony's patch looks good to me. Much clearer.

Acked-by: Jack Steiner <steiner@sgi.com>


--- jack